Syncing my Fork #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etwork-error 463/hotfix/exception on aws network error
# Conflicts: # monkey/common/cloud/aws_instance.py
Monkeyzoo update and config_schema improvements
Fixed bug in telemetry feed
… deployment_scripts_python3 # Conflicts: # deployment_scripts/deploy_linux.sh # monkey/monkey_island/linux/run.sh
…nto 393/python-3
Bugfix/remove warnings
# Conflicts: # monkey/monkey_island/cc/services/attack/attack_config.py
Updated the refresh intervals to lower server load.
…aming and other small fixes
# Conflicts: # monkey/monkey_island/cc/ui/src/components/pages/ZeroTrustReportPage.js
…ion now opens on a new tab
ATT&CK UI/UX improvements
shivank1234
pushed a commit
that referenced
this pull request
Dec 16, 2019
The rules are now set at this.rules array. While some of them have two conditions, i.e. Rule #2 shoud check if Conclusive is 0 and Inconclusive > 0, all rules has its own function (formula), which returns true or false. Eventually, I could shorten variable naming, for example, d_['Conclusive'] to something more prompt, but keeping this helps understand formulas even without referencing to upper comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature / Fixes
Have you added an explanation of what your changes do and why you'd like to include them?
Have you successfully tested your changes locally?
Example screenshot/log transcript of the feature working
Changes