Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/remove warnings #502

Merged
merged 11 commits into from
Nov 28, 2019
Merged

Bugfix/remove warnings #502

merged 11 commits into from
Nov 28, 2019

Conversation

danielguardicore
Copy link
Contributor

@danielguardicore danielguardicore commented Nov 28, 2019 •
edited
Loading

What is this?

Reduce number of warnings from our CI and code inspector.

Down to 124 from 146 as of last accepted PR.

Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Have you successfully tested your changes locally?
  • Is the TravisCI build passing?

ShayNehmad
ShayNehmad approved these changes Nov 28, 2019
View reviewed changes
Copy link
Contributor

@ShayNehmad ShayNehmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little by little 👍

@danielguardicore danielguardicore merged commit 0b22903 into develop Nov 28, 2019
@danielguardicore danielguardicore deleted the bugfix/remove_warnings branch November 28, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShayNehmad ShayNehmad ShayNehmad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielguardicore @ShayNehmad