tests: refactor install.test.ts to use jest.each

[aneeshrelan]

---

name: ⚙ Improvement
about: Refactoring tests to reduce redundancies using jest.each
labels: enhancement

---

A Pull Request should be associated with a Discussion.

Refactoring the install.test.ts to be using parameters with jest.each

Related discussion: #506

Further notes in Contribution Guidelines
Thank you for your contribution.

Description

This PR improves the test code by refactoring the install.test.ts unit tests using parameterised testing by jest.each

In case this PR introduced TypeScript/JavaScript code changes:

• I have written test cases for the changes in this pull request
• I have run npm run format before the commit.
• I have run npm run lint before the commit.
• I have run npm run release before the commit.
• npm test returns with no unit test errors and all code covered.

In case this PR edits any scripts:

• I have checked the edited scripts for syntax.
• I have tested the changes in an integration test (If yes, provide workflow YAML and link). - NA

[aneeshrelan]

Seems like the __dirname is not matching on a windows environment which is failing the check. I preferred using a Regexp based matching to avoid duplications. Thoughts? @shivammathur

[shivammathur]

Make the OS also an input parameter in the test data, then the 3 test functions can be merged into 1.

[shivammathur]

@aneeshrelan
When you convert string with path into a regular expression, it breaks on Windows as escaped slashed in path are removed.

Modify the getScript mocked function like below.

let script = 'initial script';
script += tools_csv ? ' add_tool' : '';
script += extension_csv ? ' install extensions' : '';
script += coverage_driver ? ' set coverage driver' : '';
script += ini_values_csv ? ' edit php.ini' : '';
return script;

then you can use exact matching instead of regular expresssions, for example

${'7.3'} | ${'a, b'}     | ${'a=b'}       | ${'x'}          | ${''} | ${`initial script install extensions set coverage driver edit php.ini pwsh win32.ps1 7.3 ${__dirname}`}

expect(await install.run()).toBe(output);

[aneeshrelan]

Thanks for the inputs @shivammathur. Resolved feedback, please check. Thanks

[shivammathur]

Looks great

[shivammathur]

Merged 👍