Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Use parameterised testing using jest.it.each #506

Closed
shivammathur opened this issue Sep 24, 2021 · 7 comments · Fixed by #514 or #516
Closed

Refactor: Use parameterised testing using jest.it.each #506

shivammathur opened this issue Sep 24, 2021 · 7 comments · Fixed by #514 or #516
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@shivammathur
Copy link
Owner

jest.it.each reduces the boilerplate test code and improves the readability and maintainability.
Currently config, tools and coverage tests use jest.it.each. The same can be done for utils, extensions and install tests.

Ref:

@shivammathur shivammathur added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Sep 24, 2021
@aneeshrelan
Copy link
Contributor

Can you please assign this to me? I'll try to put something up for this

@shivammathur
Copy link
Owner Author

Awesome, assigned.

@aneeshrelan
Copy link
Contributor

@shivammathur I have a draft PR up where I've done for extensions.test.ts. If you can take a look whenever you get time for some early feedback while I work on others and incorporate feedback there as well

@shivammathur
Copy link
Owner Author

Great work. I have reviewed it, also please create a different PR for each test file you work on. That will be easier for me to review.

@aneeshrelan
Copy link
Contributor

Have raised #516 for install.test.ts

@shivammathur shivammathur linked a pull request Oct 9, 2021 that will close this issue
7 tasks
@shivammathur shivammathur moved this to In Progress in setup-php Oct 10, 2021
@shivammathur
Copy link
Owner Author

Hi @aneeshrelan, will you be working on utils.test.ts as well.

@aneeshrelan
Copy link
Contributor

Yup. I can. But I won't have time this weekend. Next week I can spend some time

Repository owner moved this from In Progress to Done in setup-php Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: Done
2 participants