Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[disk][darwin] fix build with latest x/sys #956

Closed
wants to merge 1 commit into from

Conversation

tmm1
Copy link
Contributor

@tmm1 tmm1 commented Oct 7, 2020

fixes build on darwin with golang.org/x/sys v0.0.0-20201007165808-a893ed343c85

# github.com/shirou/gopsutil/disk
../../go/pkg/mod/github.com/fancybits/[email protected]+incompatible/disk/disk_darwin.go:67:51: cannot use stat.Mntfromname[:] (type []byte) as type []int8 in argument to common.IntToString
../../go/pkg/mod/github.com/fancybits/[email protected]+incompatible/disk/disk_darwin.go:68:49: cannot use stat.Mntonname[:] (type []byte) as type []int8 in argument to common.IntToString
../../go/pkg/mod/github.com/fancybits/[email protected]+incompatible/disk/disk_darwin.go:69:50: cannot use stat.Fstypename[:] (type []byte) as type []int8 in argument to common.IntToString
../../go/pkg/mod/github.com/fancybits/[email protected]+incompatible/disk/disk_darwin.go:85:43: cannot use stat.Fstypename[:] (type []byte) as type []int8 in argument to common.IntToString

@audiolion
Copy link

Created an issue #958 to track this

@Lomanic
Copy link
Collaborator

Lomanic commented Oct 8, 2020

I confirmed that it now builds with GOOS=darwin go build github.com/shirou/gopsutil/... after updating x/sys. That's the same fix as freebsd in #895 so should be good (didn't test). I think we are probably going to see similar breaking changes from x/sys with openbsd.

Could you update Gopkg.lock with dep? See https://golang.github.io/dep/docs/daily-dep.html#updating-dependencies

@Lomanic
Copy link
Collaborator

Lomanic commented Oct 15, 2020

Superseded by #970.

@Lomanic Lomanic closed this Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants