- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FreeBSD build with latest x/sys/unix #895
Merged
Merged
+9
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
There was a breaking change in upstream golang.org/x/sys/unix which changed the type of some Statvfs members, see shirou#853. As it looks like this change won't be reverted, adjust gopsutil to work with it and allow to build against the latest version of x/sys/unix.
tklauser
force-pushed
the
freebsd-statvfs-type
branch
from
June 22, 2020 21:41
d8c5dfd
to
d5eecd6
Compare
I don't have access to my computer before Sunday. Thanks for the PR and the kind word, appreciated. |
I have confirmed this patch works on latest golang.org/x/sys. Thank you for your contribute! |
hanshasselberg
added a commit
to hashicorp/consul
that referenced
this pull request
Jun 30, 2020
shirou/gopsutil#895 is merged and fixes our problem. Time to update. Since there is no new version just yet, updating to the sha.
samsalisbury
added a commit
to hashicorp/vault
that referenced
this pull request
Jun 30, 2020
- This version of gopsutil fixes the build for FreeBSD. - See shirou/gopsutil#895
hanshasselberg
added a commit
to hashicorp/consul
that referenced
this pull request
Jul 1, 2020
shirou/gopsutil#895 is merged and fixes our problem. Time to update. Since there is no new version just yet, updating to the sha.
samsalisbury
added a commit
to hashicorp/vault
that referenced
this pull request
Jul 7, 2020
- This version of gopsutil fixes the build for FreeBSD. - See shirou/gopsutil#895
briankassouf
pushed a commit
to hashicorp/vault
that referenced
this pull request
Jul 10, 2020
- This version of gopsutil fixes the build for FreeBSD. - See shirou/gopsutil#895
briankassouf
added a commit
to hashicorp/vault
that referenced
this pull request
Jul 10, 2020
- This version of gopsutil fixes the build for FreeBSD. - See shirou/gopsutil#895 Co-authored-by: Sam Salisbury <samsalisbury@gmail.com>
andaley
pushed a commit
to hashicorp/vault
that referenced
this pull request
Jul 17, 2020
- This version of gopsutil fixes the build for FreeBSD. - See shirou/gopsutil#895
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a breaking change in upstream golang.org/x/sys/unix which
changed the type of some Statfs_t members, see #853. As it looks like
this change won't be reverted, adjust gopsutil to work with it and allow
to build against the latest version of x/sys/unix.