Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FreeBSD build with latest x/sys/unix #895

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

tklauser
Copy link
Contributor

@tklauser tklauser commented Jun 22, 2020

There was a breaking change in upstream golang.org/x/sys/unix which
changed the type of some Statfs_t members, see #853. As it looks like
this change won't be reverted, adjust gopsutil to work with it and allow
to build against the latest version of x/sys/unix.

@tklauser tklauser mentioned this pull request Jun 22, 2020
@tklauser tklauser marked this pull request as draft June 22, 2020 15:57
There was a breaking change in upstream golang.org/x/sys/unix which
changed the type of some Statvfs members, see shirou#853. As it looks like
this change won't be reverted, adjust gopsutil to work with it and allow
to build against the latest version of x/sys/unix.
@tklauser tklauser force-pushed the freebsd-statvfs-type branch from d8c5dfd to d5eecd6 Compare June 22, 2020 21:41
@tklauser tklauser marked this pull request as ready for review June 22, 2020 21:42
@tklauser
Copy link
Contributor Author

@shirou @Lomanic could one of you please have a look at this if you find time? This would allow users of this package to use the latest version of golang.org/x/sys/unix again. Thank you for maintaining this useful package!

@Lomanic
Copy link
Collaborator

Lomanic commented Jun 29, 2020

I don't have access to my computer before Sunday. Thanks for the PR and the kind word, appreciated.

@shirou
Copy link
Owner

shirou commented Jun 30, 2020

I have confirmed this patch works on latest golang.org/x/sys. Thank you for your contribute!

@shirou shirou merged commit 7d13aa1 into shirou:master Jun 30, 2020
@tklauser tklauser deleted the freebsd-statvfs-type branch June 30, 2020 09:27
hanshasselberg added a commit to hashicorp/consul that referenced this pull request Jun 30, 2020
shirou/gopsutil#895 is merged and fixes our
problem. Time to update. Since there is no new version just yet,
updating to the sha.
samsalisbury added a commit to hashicorp/vault that referenced this pull request Jun 30, 2020
- This version of gopsutil fixes the build for FreeBSD.
- See shirou/gopsutil#895
hanshasselberg added a commit to hashicorp/consul that referenced this pull request Jul 1, 2020
shirou/gopsutil#895 is merged and fixes our
problem. Time to update. Since there is no new version just yet,
updating to the sha.
samsalisbury added a commit to hashicorp/vault that referenced this pull request Jul 7, 2020
- This version of gopsutil fixes the build for FreeBSD.
- See shirou/gopsutil#895
briankassouf pushed a commit to hashicorp/vault that referenced this pull request Jul 10, 2020
- This version of gopsutil fixes the build for FreeBSD.
- See shirou/gopsutil#895
briankassouf added a commit to hashicorp/vault that referenced this pull request Jul 10, 2020
- This version of gopsutil fixes the build for FreeBSD.
- See shirou/gopsutil#895

Co-authored-by: Sam Salisbury <samsalisbury@gmail.com>
andaley pushed a commit to hashicorp/vault that referenced this pull request Jul 17, 2020
- This version of gopsutil fixes the build for FreeBSD.
- See shirou/gopsutil#895
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants