fix(fabric.Textbox): Do not let splitbygrapheme split text previously…

… unwrapped. (fabricjs#6621) * fix(fabric.Textbox): The same text does not need to be wrapped * fix(Lint): lint test case
shanicerae · Jan 16, 2021 · 0ce486f · 0ce486f
1 parent 9f65200
commit 0ce486f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/shapes/textbox.class.js b/src/shapes/textbox.class.js
@@ -335,7 +335,7 @@
         offset += word.length;
 
         lineWidth += infixWidth + wordWidth - additionalSpace;
-        if (lineWidth >= desiredWidth && !lineJustStarted) {
+        if (lineWidth > desiredWidth && !lineJustStarted) {
           graphemeLines.push(line);
           line = [];
           lineWidth = wordWidth;

diff --git a/test/unit/textbox.js b/test/unit/textbox.js
@@ -516,4 +516,18 @@
     assert.equal(textbox.styleHas('fontFamily', 1), true, 'style has fontFamily on line 1');
   });
 
+  QUnit.test('The same text does not need to be wrapped.', function(assert) {
+    var str = '0123456789';
+    var measureTextbox = new fabric.Textbox(str, {
+      fontSize: 20,
+      splitByGrapheme: false,
+    });
+    var newTextbox = new fabric.Textbox(str, {
+      width: measureTextbox.width,
+      fontSize: 20,
+      splitByGrapheme: true,
+    });
+    assert.equal(newTextbox.textLines.length, measureTextbox.textLines.length, 'The same text is not wrapped');
+  });
+
 })();