Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fabric.Textbox): The same text does not need to be wrapped #6621

Merged
merged 2 commits into from
Sep 30, 2020
Merged

fix(fabric.Textbox): The same text does not need to be wrapped #6621

merged 2 commits into from
Sep 30, 2020

Conversation

proYang
Copy link
Contributor

@proYang proYang commented Sep 27, 2020

Hi, I encountered and fixed the problem. 🐛

@proYang
Copy link
Contributor Author

proYang commented Sep 27, 2020

I have added some test cases that require npm run build.

@asturur
Copy link
Member

asturur commented Sep 27, 2020

can you explain a bit better what the bug was about? can you reproduce it?

@proYang
Copy link
Contributor Author

proYang commented Sep 28, 2020 •
edited
Loading

can you explain a bit better what the bug was about? can you reproduce it?

I wrote an example. https://jsfiddle.net/slaneyang/5pbwon19/

QQ20200928-111211-HD

The same text, the same width, there is no need to break the line.

@housseynCheriet
Copy link

Best explanation of easing function
https://www.selectionjs.com/animation

@asturur
Copy link
Member

asturur commented Sep 30, 2020

Ok is a bit more clear now.
if you open a PR please take care that the people maintaining the library can understand where the problem is, and how to trigger it.

@asturur
Copy link
Member

asturur commented Sep 30, 2020

Something is failing with lint. Did you run npm run lint_tests?

@proYang
Copy link
Contributor Author

proYang commented Sep 30, 2020

Something is failing with lint. Did you run npm run lint_tests?

Oh! Just a moment. I'll fix it.

@proYang
Copy link
Contributor Author

proYang commented Sep 30, 2020

Something is failing with lint. Did you run npm run lint_tests?

Oh! Just a moment. I'll fix it.

@asturur done

@asturur
Copy link
Member

asturur commented Sep 30, 2020

Thanks!

@asturur asturur merged commit 2819324 into fabricjs:master Sep 30, 2020
@asturur asturur mentioned this pull request Dec 23, 2020
Merged
shanicerae pushed a commit to shanicerae/fabric.js that referenced this pull request Jan 16, 2021
@proYang @shanicerae
fix(fabric.Textbox): Do not let splitbygrapheme split text previously…
0ce486f 
… unwrapped. (fabricjs#6621)

* fix(fabric.Textbox): The same text does not need to be wrapped

* fix(Lint): lint test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asturur asturur asturur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@proYang @asturur @housseynCheriet