Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarn JS Dependencies Updated #425

Merged
merged 1 commit into from
Nov 28, 2017

Conversation

reconstructions
Copy link
Contributor

@reconstructions reconstructions commented Nov 27, 2017

Yarn Dependencies Updated:

I updated all yarn packages in client/package.json to their latest non-alpha, beta, or release candidate versions. react_on_rails was bumped to version 10.0.2. babel-preset-es2015 was migrated to babel-preset-env, as recommended.

This got about half of the yarn install warning errors resolved. Here are some details:

babel deprecated in favor of babel-cli:

"babel": "^6.23.0" was removed from package.json to resolve yarn install deprecation warning:

warning [email protected]: In 6.x, the babel package has been deprecated in favor of babel-cli.

react-addons-css-transition-group peer dependencies:

"react-addons-css-transition-group": "^15.6.2" gives this warning on a fresh yarn install:

warning "[email protected]" has incorrect peer dependency "react@^15.4.2".

But I didn't update it because the available 16.x.x versions are still in alpha:

'16.0.0-alpha',
'16.0.0-alpha.0',
'16.0.0-alpha.2',
'16.0.0-alpha.3'

eslint-plugin-jsx-a11y peer dependencies:

"eslint-plugin-jsx-a11y": ""^6.0.2"" gives this warning on a fresh yarn install:

warning "[email protected]" has incorrect peer dependency "eslint-plugin-jsx-a11y@^5.1.1".

This was resolved by rolling eslint-plugin-jsx-a11y back to version 5.1.1 in client/package.json.

chai-immutable Peer Dependencies:

"chai-immutable": "^15.6.2" gives this warning on a fresh yarn install:

warning "[email protected]" has incorrect peer dependency "chai@>= 2.0.0 < 4".

But I didn't update it because the only 2.0.0 version is still alpha: 2.0.0-alpha.1.

eslint-config-shakacode Peer Dependencies:

"eslint-config-shakacode": "^15.0.0" gives this warning:

warning "[email protected]" has incorrect peer dependency "eslint@^3.15.0".

Since this is a ShakaCode package I tried bumping it to the latest version (16.0.0-rc.3), which resulted in 29 errors that couldn't be fixed automatically using the --fix flag. So I rolled back to 15.0.0 and will fix these errors in a follow-on commit.

Use uuid instead of node-uuid:

We get this warning on a fresh yarn install:

warning [email protected]: Use uuid module instead

But I didn't change this because it is used in server-express.js, and it didn't want to take the change of introducing a second error into hot reloading if it can't be smoke tested.


This change is Reviewable

@justin808 justin808 merged commit 380c89a into shakacode:master Nov 28, 2017
@justin808
Copy link
Member

Thanks @reconstructions! Outstanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants