Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yarn Dependencies Updated:
I updated all yarn packages in
client/package.json
to their latest non-alpha, beta, or release candidate versions.react_on_rails
was bumped to version10.0.2
.babel-preset-es2015
was migrated tobabel-preset-env
, as recommended.This got about half of the
yarn install
warning errors resolved. Here are some details:babel
deprecated in favor ofbabel-cli
:"babel": "^6.23.0"
was removed frompackage.json
to resolveyarn install
deprecation warning:react-addons-css-transition-group peer dependencies:
"react-addons-css-transition-group": "^15.6.2"
gives this warning on a freshyarn install
:But I didn't update it because the available 16.x.x versions are still in alpha:
eslint-plugin-jsx-a11y peer dependencies:
"eslint-plugin-jsx-a11y": ""^6.0.2""
gives this warning on a freshyarn install
:This was resolved by rolling
eslint-plugin-jsx-a11y
back to version5.1.1
inclient/package.json
.chai-immutable Peer Dependencies:
"chai-immutable": "^15.6.2"
gives this warning on a freshyarn install
:But I didn't update it because the only 2.0.0 version is still alpha:
2.0.0-alpha.1
.eslint-config-shakacode Peer Dependencies:
"eslint-config-shakacode": "^15.0.0"
gives this warning:Since this is a ShakaCode package I tried bumping it to the latest version (
16.0.0-rc.3
), which resulted in 29 errors that couldn't be fixed automatically using the--fix
flag. So I rolled back to15.0.0
and will fix these errors in a follow-on commit.Use
uuid
instead ofnode-uuid
:We get this warning on a fresh
yarn install
:warning [email protected]: Use uuid module instead
But I didn't change this because it is used in
server-express.js
, and it didn't want to take the change of introducing a second error into hot reloading if it can't be smoke tested.This change is