-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heroku deployment fails with rake task error starting in commit #421 #429
Comments
If I change commit #416 to use the engine specs from the commit #421 package.json, pushing to Heroku fails this way. If I rollback all the changes made since commit #416 in commit #426, that fixes it. I've tried each option a couple times. |
I made a PR which fixes pushing to Heroku by rolling Yarn back to version 0.22.0. The only other lines which need to be rolled back to #416 are bits of syntax in the client/package.json scripts. There are a bunch of issues with proposed solutions to similar errors, but it looks like they could have different causes and none of them worked here. It is also unclear whether this is really a webpacker, yarn, heroku, or react_on_rails issue: webpacker#821 I will follow up and see if I can figure anything out by looking more closely at how the react_on_rails gem is is working with yarn 1.3.2 on Heroku. |
Starting in commit #421, webpack asset precompilation fails with the following error when pushing to Heroku:
I get the same error pushing commits #424, #425, and #426. Commits #416 and earlier push with no problem.
I will try to figure out what the breaking change was.
The text was updated successfully, but these errors were encountered: