Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error raised in the period eviction spotted on PS5 #7722

Closed
Iragne opened this issue Dec 6, 2024 · 2 comments · Fixed by #7723
Closed

Error raised in the period eviction spotted on PS5 #7722

Iragne opened this issue Dec 6, 2024 · 2 comments · Fixed by #7723
Assignees
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P1 Big impact or workaround impractical; resolve before feature release type: bug Something isn't working correctly
Milestone

Comments

@Iragne
Copy link
Contributor

Iragne commented Dec 6, 2024

Have you read the FAQ and checked for duplicate open issues?

Yes
If the problem is related to FairPlay, have you read the tutorial?

No

What version of Shaka Player are you using?

today in 4.12.1

Can you reproduce the issue with our latest release version?
We working on this i will let you know shortly

Can you reproduce the issue with the latest code from main?
We working on this i will let you know shortly

Are you using the demo app or your own custom app?

Yes
If custom app, can you reproduce the issue using our demo app?

What browser and OS are you using?
Today we spotted it on PS5

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

https://d24rwxnt7vw9qb.cloudfront.net/v1/dash/e6d234965645b411ad572802b6c9d5a10799c9c1/All_Reference_Streams/ee565ea510cb4b4d8df5f48918c3d6dc/index.mpd

What configuration are you using? What is the output of player.getNonDefaultConfiguration()?

default with a limitation of the ABR to the smallest rendition to avoid and Quality switch
player.configure("abr.restrictions.maxBandwidth", 10e3);

What did you do?

Play for more than 1h

What did you expect to happen?

No error message

What actually happened?

We are seeing this error message
Type Error undefined is not an object evalating s.segmentIndex
Look associated to cleanStreamMap_() {
if (stream.segmentIndex && !stream.segmentIndex.isEmpty()) {
Where stream is undefined....

Screenshot 2024-12-06 at 11 44 28

Are you planning send a PR to fix it?
If i found the issue yes

@Iragne Iragne added the type: bug Something isn't working correctly label Dec 6, 2024
@shaka-bot shaka-bot added this to the v4.13 milestone Dec 6, 2024
@Iragne
Copy link
Contributor Author

Iragne commented Dec 6, 2024

Look releated to the refactor here d8a14b0#diff-abddb185c4fb1df35b1c9a4f11b32f2e6112c7c0d6d33c882dcca9ba583f1c13L1507
and here too
#7301

Where we expect to have stream still available as part of the map
But indexStreamMap_ is not retaining the stream only the ref.
The code added was suggesting that the stream will exist in the stream map but can be deleted by
delete this.streamMap_[contextId];
if we have double occurence of the context id as part of the indexStreamMap_[pid]

Look like my first implementation had move to something more complex with more expectation.
cleanStreamMap_ was designed to clean any duplication or retention

@Iragne
Copy link
Contributor Author

Iragne commented Dec 6, 2024

@avelad just let me know your thought as you refactor the code

@avelad avelad added component: DASH The issue involves the MPEG DASH manifest format priority: P1 Big impact or workaround impractical; resolve before feature release labels Dec 9, 2024
avelad pushed a commit that referenced this issue Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P1 Big impact or workaround impractical; resolve before feature release type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants