fix(DASH): Fix playback after DASH period eviction (#7603)

Fixes #7516 in a simpler way Reverts 5eff038 Reverts 037193c
shaka-project · Nov 15, 2024 · d8a14b0 · d8a14b0
1 parent 997515a
commit d8a14b0
Show file tree

Hide file tree

Showing 22 changed files with 12 additions and 209 deletions.
diff --git a/externs/shaka/manifest_parser.js b/externs/shaka/manifest_parser.js
@@ -140,7 +140,6 @@ shaka.extern.ManifestParser = class {
  *   getBandwidthEstimate: function():number,
  *   onMetadata: function(string, number, ?number,
  *                        !Array.<shaka.extern.MetadataFrame>),
- *   closeSegmentIndex: function(shaka.extern.Stream, function()),
  *   disableStream: function(!shaka.extern.Stream),
  *   addFont: function(string, string)
  * }}
@@ -187,8 +186,6 @@ shaka.extern.ManifestParser = class {
  * @property {function(!shaka.extern.Stream)} disableStream
  *   Called to temporarily disable a stream i.e. disabling all variant
  *   containing said stream.
- * @property {function(!shaka.extern.Stream, function())} closeSegmentIndex
- *   Called to close a segment index.
  * @property {function(string, string)} addFont
  *   Called when a new font needs to be added.
  * @exportDoc

diff --git a/lib/dash/dash_parser.js b/lib/dash/dash_parser.js
@@ -239,9 +239,6 @@ shaka.dash.DashParser = class {
     this.lowLatencyMode_ = playerInterface.isLowLatencyMode();
     this.manifestUris_ = [uri];
     this.playerInterface_ = playerInterface;
-    if (this.periodCombiner_) {
-      this.periodCombiner_.setPlayerInterface(this.playerInterface_);
-    }
 
     const updateDelay = await this.requestManifest_();
 
@@ -684,7 +681,6 @@ shaka.dash.DashParser = class {
     }
 
     this.manifestPatchContext_.type = mpdType;
-    this.cleanStreamMap_();
     /** @type {!shaka.media.PresentationTimeline} */
     let presentationTimeline;
     if (this.manifest_) {
@@ -861,6 +857,8 @@ shaka.dash.DashParser = class {
     // after period combining, while we still have a direct reference, so that
     // any new streams will appear in the period combiner.
     this.playerInterface_.makeTextStreamsForClosedCaptions(this.manifest_);
+
+    this.cleanStreamMap_();
   }
 
   /**
@@ -1504,13 +1502,21 @@ shaka.dash.DashParser = class {
       return !this.lastManifestUpdatePeriodIds_.includes(pId);
     });
     for (const pId of diffPeriodsIDs) {
+      let shouldDeleteIndex = true;
       for (const contextId of this.indexStreamMap_[pId]) {
+        const stream = this.streamMap_[contextId];
+        if (stream.segmentIndex && !stream.segmentIndex.isEmpty()) {
+          shouldDeleteIndex = false;
+          continue;
+        }
         if (this.periodCombiner_) {
           this.periodCombiner_.deleteStream(this.streamMap_[contextId], pId);
         }
         delete this.streamMap_[contextId];
       }
-      delete this.indexStreamMap_[pId];
+      if (shouldDeleteIndex) {
+        delete this.indexStreamMap_[pId];
+      }
     }
   }
 

diff --git a/lib/media/streaming_engine.js b/lib/media/streaming_engine.js
@@ -513,32 +513,6 @@ shaka.media.StreamingEngine = class {
     }
   }
 
-  /**
-   * closeSegmentIndex if the stream is not active
-   * @param {shaka.extern.Stream} stream
-   * @param {function()} closeSegmentIndex
-   */
-  closeSegmentIndex(stream, closeSegmentIndex) {
-    const type = /** @type {!shaka.util.ManifestParserUtils.ContentType} */
-            (stream.type);
-    const mediaState = this.mediaStates_.get(type);
-    if (mediaState) {
-      /**
-       * Closes the segmentIndex only if the stream is not active.
-       * If the stream is active the eviction will be peformed
-       * by the next onUpdate_().
-      */
-      const matchedStreams = mediaState.stream.matchedStreams;
-      const found = matchedStreams.find((match) => match.id === stream.id);
-      if (!found) {
-        closeSegmentIndex();
-      }
-    } else {
-      // type of stream not active
-      closeSegmentIndex();
-    }
-  }
-
 
   /**
    * Handles deferred releases of old SegmentIndexes for the mediaState's

diff --git a/lib/offline/storage.js b/lib/offline/storage.js
@@ -1217,7 +1217,6 @@ shaka.offline.Storage = class {
       onManifestUpdated: () => {},
       getBandwidthEstimate: () => config.abr.defaultBandwidthEstimate,
       onMetadata: () => {},
-      closeSegmentIndex: (stream, closeSegmentIndex) => {},
       disableStream: (stream) => {},
       addFont: (name, url) => {},
     };

diff --git a/lib/player.js b/lib/player.js
@@ -2161,13 +2161,6 @@ shaka.Player = class extends shaka.util.FakeEventTarget {
           });
         }
       },
-      closeSegmentIndex: (stream, closeSegmentIndex) => {
-        if (this.streamingEngine_) {
-          this.streamingEngine_.closeSegmentIndex(stream, closeSegmentIndex);
-        } else {
-          closeSegmentIndex();
-        }
-      },
       disableStream: (stream) => this.disableStream(
           stream, this.config_.streaming.maxDisabledTime),
       addFont: (name, url) => this.addFont(name, url),

diff --git a/lib/util/periods.js b/lib/util/periods.js
@@ -48,9 +48,6 @@ shaka.util.PeriodCombiner = class {
     /** @private {boolean} */
     this.useStreamOnce_ = false;
 
-    /** @private {?shaka.extern.ManifestParser.PlayerInterface} */
-    this.playerInterface_ = null;
-
     /**
      * The IDs of the periods we have already used to generate streams.
      * This helps us identify the periods which have been added when a live
@@ -83,15 +80,6 @@ shaka.util.PeriodCombiner = class {
     this.usedPeriodIds_.clear();
   }
 
-  /**
-   * @param {?shaka.extern.ManifestParser.PlayerInterface} playerInterface
-   *
-   * @export
-  */
-  setPlayerInterface(playerInterface) {
-    this.playerInterface_ = playerInterface;
-  }
-
   /**
    * @return {!Array.<shaka.extern.Variant>}
    *
@@ -167,19 +155,8 @@ shaka.util.PeriodCombiner = class {
       }
     }
     if (stream.segmentIndex) {
-      if (this.playerInterface_) {
-        const closeSegmentIndex = () => {
-          stream.closeSegmentIndex();
-        };
-
-        this.playerInterface_.closeSegmentIndex(
-            stream,
-            closeSegmentIndex);
-      } else {
-        stream.closeSegmentIndex();
-      }
+      stream.closeSegmentIndex();
     }
-
     this.usedPeriodIds_.delete(periodId);
   }
 

diff --git a/test/dash/dash_parser_content_protection_unit.js b/test/dash/dash_parser_content_protection_unit.js
@@ -47,7 +47,6 @@ describe('DashParser ContentProtection', () => {
       onManifestUpdated: () => {},
       getBandwidthEstimate: () => 1e6,
       onMetadata: () => {},
-      closeSegmentIndex: (stream, closeSegmentIndex) => {},
       disableStream: (stream) => {},
       addFont: (name, url) => {},
     };

diff --git a/test/dash/dash_parser_live_unit.js b/test/dash/dash_parser_live_unit.js
@@ -39,7 +39,6 @@ describe('DashParser Live', () => {
       onManifestUpdated: () => {},
       getBandwidthEstimate: () => 1e6,
       onMetadata: () => {},
-      closeSegmentIndex: (stream, closeSegmentIndex) => {},
       disableStream: (stream) => {},
       addFont: (name, url) => {},
     };

diff --git a/test/dash/dash_parser_manifest_unit.js b/test/dash/dash_parser_manifest_unit.js
@@ -60,7 +60,6 @@ describe('DashParser Manifest', () => {
       onManifestUpdated: () => {},
       getBandwidthEstimate: () => 1e6,
       onMetadata: () => {},
-      closeSegmentIndex: (stream, closeSegmentIndex) => {},
       disableStream: (stream) => {},
       addFont: shaka.test.Util.spyFunc(addFontSpy),
     };

diff --git a/test/dash/dash_parser_patch_unit.js b/test/dash/dash_parser_patch_unit.js
@@ -50,7 +50,6 @@ describe('DashParser Patch', () => {
       onManifestUpdated: () => {},
       getBandwidthEstimate: () => 1e6,
       onMetadata: () => {},
-      closeSegmentIndex: (stream, closeSegmentIndex) => {},
       disableStream: (stream) => {},
       addFont: (name, url) => {},
     };

diff --git a/test/dash/dash_parser_segment_base_unit.js b/test/dash/dash_parser_segment_base_unit.js
@@ -43,7 +43,6 @@ describe('DashParser SegmentBase', () => {
       onManifestUpdated: () => {},
       getBandwidthEstimate: () => 1e6,
       onMetadata: () => {},
-      closeSegmentIndex: (stream, closeSegmentIndex) => {},
       disableStream: (stream) => {},
       addFont: (name, url) => {},
     };

diff --git a/test/dash/dash_parser_segment_list_unit.js b/test/dash/dash_parser_segment_list_unit.js
@@ -353,7 +353,6 @@ describe('DashParser SegmentList', () => {
       onManifestUpdated: () => {},
       getBandwidthEstimate: () => 1e6,
       onMetadata: () => {},
-      closeSegmentIndex: (stream, closeSegmentIndex) => {},
       disableStream: (stream) => {},
       addFont: (name, url) => {},
     };

diff --git a/test/dash/dash_parser_segment_template_unit.js b/test/dash/dash_parser_segment_template_unit.js
@@ -52,7 +52,6 @@ describe('DashParser SegmentTemplate', () => {
       onManifestUpdated: () => {},
       getBandwidthEstimate: () => 1e6,
       onMetadata: () => {},
-      closeSegmentIndex: (stream, closeSegmentIndex) => {},
       disableStream: (stream) => {},
       addFont: (name, url) => {},
     };

diff --git a/test/hls/hls_live_unit.js b/test/hls/hls_live_unit.js
@@ -82,7 +82,6 @@ describe('HlsParser live', () => {
       onManifestUpdated: () => {},
       getBandwidthEstimate: () => 1e6,
       onMetadata: () => {},
-      closeSegmentIndex: (stream, closeSegmentIndex) => {},
       disableStream: (stream) => {},
       addFont: (name, url) => {},
     };

diff --git a/test/hls/hls_parser_unit.js b/test/hls/hls_parser_unit.js
@@ -96,7 +96,6 @@ describe('HlsParser', () => {
       onManifestUpdated: () => {},
       getBandwidthEstimate: () => 1e6,
       onMetadata: shaka.test.Util.spyFunc(onMetadataSpy),
-      closeSegmentIndex: (stream, closeSegmentIndex) => {},
       disableStream: (stream) => {},
       addFont: (name, url) => {},
     };

diff --git a/test/media/streaming_engine_integration.js b/test/media/streaming_engine_integration.js
@@ -271,8 +271,6 @@ describe('StreamingEngine', () => {
       onSegmentAppended: () => playhead.notifyOfBufferingChange(),
       onInitSegmentAppended: () => {},
       beforeAppendSegment: () => Promise.resolve(),
-      onMetadata: () => {},
-      closeSegmentIndex: (stream, closeSegmentIndex) => {},
       disableStream: (stream, time) => false,
     };
     streamingEngine = new shaka.media.StreamingEngine(

diff --git a/test/media/streaming_engine_unit.js b/test/media/streaming_engine_unit.js
@@ -467,7 +467,6 @@ describe('StreamingEngine', () => {
       onSegmentAppended: Util.spyFunc(onSegmentAppended),
       onInitSegmentAppended: () => {},
       beforeAppendSegment: Util.spyFunc(beforeAppendSegment),
-      closeSegmentIndex: (stream, closeSegmentIndex) => {},
       disableStream: Util.spyFunc(disableStream),
     };
     streamingEngine = new shaka.media.StreamingEngine(

diff --git a/test/mss/mss_parser_unit.js b/test/mss/mss_parser_unit.js
@@ -82,7 +82,6 @@ describe('MssParser Manifest', () => {
       onManifestUpdated: () => {},
       getBandwidthEstimate: () => 1e6,
       onMetadata: () => {},
-      closeSegmentIndex: (stream, closeSegmentIndex) => {},
       disableStream: (stream) => {},
       addFont: (name, url) => {},
     };

diff --git a/test/test/util/dash_parser_util.js b/test/test/util/dash_parser_util.js
@@ -48,7 +48,6 @@ shaka.test.Dash = class {
       onManifestUpdated: () => {},
       getBandwidthEstimate: () => 1e6,
       onMetadata: () => {},
-      closeSegmentIndex: (stream, closeSegmentIndex) => {},
       disableStream: (stream) => {},
       addFont: (name, url) => {},
     };
@@ -99,7 +98,6 @@ shaka.test.Dash = class {
       onManifestUpdated: () => {},
       getBandwidthEstimate: () => 1e6,
       onMetadata: () => {},
-      closeSegmentIndex: (stream, closeSegmentIndex) => {},
       disableStream: (stream) => {},
       addFont: (name, url) => {},
     };

diff --git a/test/test/util/mss_parser_util.js b/test/test/util/mss_parser_util.js
@@ -48,7 +48,6 @@ shaka.test.Mss = class {
       onManifestUpdated: () => {},
       getBandwidthEstimate: () => 1e6,
       onMetadata: () => {},
-      closeSegmentIndex: (stream, closeSegmentIndex) => {},
       disableStream: (stream) => {},
       addFont: (name, url) => {},
     };
@@ -90,7 +89,6 @@ shaka.test.Mss = class {
       onManifestUpdated: () => {},
       getBandwidthEstimate: () => 1e6,
       onMetadata: () => {},
-      closeSegmentIndex: (stream, closeSegmentIndex) => {},
       disableStream: (stream) => {},
       addFont: (name, url) => {},
     };

diff --git a/test/util/content_steering_manager_unit.js b/test/util/content_steering_manager_unit.js
@@ -30,7 +30,6 @@ describe('ContentSteeringManager', () => {
       onManifestUpdated: fail,
       getBandwidthEstimate: () => 1e6,
       onMetadata: () => {},
-      closeSegmentIndex: (stream, closeSegmentIndex) => {},
       disableStream: (stream) => {},
       addFont: (name, url) => {},
     };