Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DASH] Possibility of playback freezes after an eviction of the period combined with a switchInternal_() and a fetchAndAppend() #7516

Closed
ncocaign opened this issue Oct 28, 2024 · 0 comments · Fixed by #7519, #7589 or #7603
Assignees
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Milestone

Comments

@ncocaign
Copy link
Contributor

ncocaign commented Oct 28, 2024

Have you read the FAQ and checked for duplicate open issues?
Yes

If the problem is related to FairPlay, have you read the tutorial?

What version of Shaka Player are you using?

all versions > 4.10.16 and 4.11, main, 4.11.9

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
Yes

Are you using the demo app or your own custom app?
demo app

If custom app, can you reproduce the issue using our demo app?

What browser and OS are you using?
Google Chrome, FireFox, Ms Edge

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

I cannot shared publicly urls.

What configuration are you using? What is the output of player.getNonDefaultConfiguration()?

{
    "preferredAudioLanguage": "fr-FR",
    "preferredTextLanguage": "fr-FR"
}

What did you do?

Playing a live DASH stream with multi-periods for DAI/Blackout.

What did you expect to happen?
Smooth playback without skipping a segment.

What actually happened?

We have something similiar to this bug #7156.
The issues seems introduced by the commit 729afb1.

The issue is always seen when a stream of a period is removed inside PeriodCombiner.deleteStream() and just after a StreamingEngine.switchInternal_() occurs at the same than an ongoing StreamingEngine.fetchAndAppend_() `.

In the context of DASH, this is the result of the release of the SegmentIndex.references array and SegmentIndex._templateInfo. At the end of StreamingEngine.fetchAndAppend_() we have 2 non continious timelines:
finished fetch and append [{"start":1730126446.310988,"end":1730126476.326988},{"start":1730126482.342988,"end":1730126488.337654}]

Here some logs with extra information (noted [SYNAMEDIA]) for tracking the issue:
v4-11-10-dot-shaka-player-demo.appspot.com-1730126722245.log

Are you planning send a PR to fix it?
Yes, and the plan is do the the same kind of thing than with #7156 by defering the call of the Stream.closeSegmentIndex() in a safe timing.

@ncocaign ncocaign added the type: bug Something isn't working correctly label Oct 28, 2024
@ncocaign ncocaign changed the title [DASH] Possibility of playback freezes after an eviction of the period combined to a switching of streams and ``StreamEngine.fetchAndAppend() [DASH] Possibility of playback freezes after an eviction of the period combined with a switchInternal_() and a fetchAndAppend() Oct 28, 2024
@shaka-bot shaka-bot added this to the v4.12 milestone Oct 28, 2024
ncocaign added a commit to ncocaign/shaka-player that referenced this issue Oct 29, 2024
fix(DASH): Fix playback of some DASH with multiple period (shaka-project#7516)

With this change, closeSegmentIndex() of stream removed of a period are defered in StreamingEngine.onUpdate_()

Fixes shaka-project#7517
ncocaign added a commit to ncocaign/shaka-player that referenced this issue Oct 29, 2024
…ect#7516)

With this change, closeSegmentIndex() of all streams of a removed period are defered in StreamingEngine.onUpdate_()

Fixes shaka-project#7516
@avelad avelad added priority: P2 Smaller impact or easy workaround component: DASH The issue involves the MPEG DASH manifest format labels Oct 31, 2024
@avelad avelad modified the milestones: v4.12, v4.13 Nov 13, 2024
ncocaign added a commit to ncocaign/shaka-player that referenced this issue Nov 13, 2024
…ect#7516)

With this change, closeSegmentIndex() of all streams of a removed period are defered in StreamingEngine.onUpdate_()

Fixes shaka-project#7516
joeyparrish pushed a commit that referenced this issue Nov 13, 2024
avelad added a commit that referenced this issue Nov 15, 2024
avelad pushed a commit that referenced this issue Nov 15, 2024
With this change, closeSegmentIndex() of all streams of a removed period
are defered in StreamingEngine.onUpdate_()

Fixes #7516
avelad pushed a commit that referenced this issue Nov 15, 2024
avelad added a commit that referenced this issue Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment