Fix: Java 18+ Builds #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgammon
force-pushed
the
chore/build-jdk21
branch
from
90cb46e
to
f8b687a
Compare
- fix: build against embedded jdk sources needs `--enable-preview` when built against jvm21 - fix: add `-Djava.security.manager=allow` to fix security manager tests under modern java Fixes and closes google#7065 Signed-off-by: Sam Gammon <[email protected]>
Signed-off-by: Sam Gammon <[email protected]>
sgammon
force-pushed
the
chore/build-jdk21
branch
from
2c02d4e
to
77cd546
Compare
sgammon
added
enhancement
sgammon
force-pushed
the
master
branch
7 times, most recently
from
5801bcf
to
0b1c477
Compare
|
(This was a draft, closing) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Amends the build to be compatible with JDKs newer than 18.
Note
This PR is under testing before it is ultimately filed against
google/guava.Changelog
--enable-previewwhen built against jvm21-Djava.security.manager=allowto fix security manager tests under modern java