-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guava build fails on master
with JDK 21
#7065
Comments
master
master
with JDK 21
It appears this happens because of the build against JDK sources, which includes preview types. |
Thanks, I knew that the build was broken at one point under 21 (#6830, maybe since fixed, but we should set up CI, as the issue says) but didn't know about this specific reason. It's probably about time for me to do something about that. The use of JDK sources hasn't been working for a while, anyway (#6790). I should probably rip that out. |
Would you guys be open to PRs @cpovirk? I have a reasonable suite of changes locally and I could break that out into something reviewable. |
For this sort of thing, probably yes, thanks. The main thing to be aware of is the need to sign the CLA: https://github.com/google/guava/blob/master/CONTRIBUTING.md#contributor-license-agreement If you want me to peek at anything before you go to the trouble of breaking it up, let me know. |
- fix: build against embedded jdk sources needs `--enable-preview` when built against jvm21 - fix: add `-Djava.security.manager=allow` to fix security manager tests under modern java Fixes and closes google#7065 Signed-off-by: Sam Gammon <[email protected]>
- fix: build against embedded jdk sources needs `--enable-preview` when built against jvm21 - fix: add `-Djava.security.manager=allow` to fix security manager tests under modern java Fixes and closes google#7065 Signed-off-by: Sam Gammon <[email protected]>
- fix: build against embedded jdk sources needs `--enable-preview` when built against jvm21 - fix: add `-Djava.security.manager=allow` to fix security manager tests under modern java Fixes and closes google#7065 Signed-off-by: Sam Gammon <[email protected]>
- fix: build against embedded jdk sources needs `--enable-preview` when built against jvm21 - fix: add `-Djava.security.manager=allow` to fix security manager tests under modern java Fixes and closes google#7065 Signed-off-by: Sam Gammon <[email protected]>
- fix: build against embedded jdk sources needs `--enable-preview` when built against jvm21 - fix: add `-Djava.security.manager=allow` to fix security manager tests under modern java Fixes and closes google#7065 Signed-off-by: Sam Gammon <[email protected]>
- fix: build against embedded jdk sources needs `--enable-preview` when built against jvm21 - fix: add `-Djava.security.manager=allow` to fix security manager tests under modern java Fixes and closes google#7065 Signed-off-by: Sam Gammon <[email protected]>
- fix: build against embedded jdk sources needs `--enable-preview` when built against jvm21 - fix: add `-Djava.security.manager=allow` to fix security manager tests under modern java Fixes and closes google#7065 Signed-off-by: Sam Gammon <[email protected]>
- fix: build against embedded jdk sources needs `--enable-preview` when built against jvm21 - fix: add `-Djava.security.manager=allow` to fix security manager tests under modern java Fixes and closes google#7065 Signed-off-by: Sam Gammon <[email protected]>
- fix: build against embedded jdk sources needs `--enable-preview` when built against jvm21 - fix: add `-Djava.security.manager=allow` to fix security manager tests under modern java Fixes and closes google#7065 Signed-off-by: Sam Gammon <[email protected]>
- fix: build against embedded jdk sources needs `--enable-preview` when built against jvm21 - fix: add `-Djava.security.manager=allow` to fix security manager tests under modern java Fixes and closes google#7065 Signed-off-by: Sam Gammon <[email protected]>
- fix: build against embedded jdk sources needs `--enable-preview` when built against jvm21 - fix: add `-Djava.security.manager=allow` to fix security manager tests under modern java Fixes and closes google#7065 Signed-off-by: Sam Gammon <[email protected]>
The main changes is that tests need `-Djava.security.manager=allow`. Fixes and closes #7065 Helps with #6790 Fixes #6245 (at least the remaining parts that we actually care about) Fixes #7087 Signed-off-by: Sam Gammon <[email protected]> RELNOTES=n/a PiperOrigin-RevId: 614671411
The main changes is that tests need `-Djava.security.manager=allow`. Fixes and closes #7065 Helps with #6790 Fixes #6245 (at least the remaining parts that we actually care about) Fixes #7087 Signed-off-by: Sam Gammon <[email protected]> RELNOTES=n/a PiperOrigin-RevId: 614671411
The main changes is that tests need `-Djava.security.manager=allow`. Fixes and closes #7065 Helps with #6790 Fixes #6245 (at least the remaining parts that we actually care about) Fixes #7087 Signed-off-by: Sam Gammon <[email protected]> RELNOTES=n/a PiperOrigin-RevId: 614671411
Description
Using latest LTS JVM (21):
git clone [email protected]:google/guava.git
cd guava && mvn clean package
Example
Expected Behavior
The build should not fail
Actual Behavior
Packages
No response
Platforms
No response
Checklist
The text was updated successfully, but these errors were encountered: