-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full rendering - first glance #5
Comments
Some comments from my side, apologies if this duplicates information stated elsewhere:
Easily fixed in metadata, but perhaps the translator can also extract the information in a smarter way?
An additional step could be to include the project name as a keyword in the cff file.
For context, any dataset in the catalog can have keywords that were provided via metadata, and if datasets containing keywords are listed as subdatasets of a particular dataset, all of these keywords spanning subdatasets together will constitute the keyword search space.
@adswa I am not sure whether it would be sensible to omit the keyword search if there aren't any subdataset keywords. This is a general UX challenge: figuring out what to hide or display based on the availability of content. Hiding it makes for an unpredictable UX (the search field is sometimes there, sometimes not), and showing it in the absence of keywords could be confusing. I lean towards the former, but can be convinced otherwise. W.r.t. the SFB catalog in particular, i think we should manually curate some keywords, it would make the catalog better to interact with.
@mih For clarity, does this mean displaying the number of subdatasets of a _sub_dataset? Certainly possible. Relevant catalog issue: datalad/datalad-catalog#280
@mih It's easy to show the publications if other tabs are empty, but I'm not sure what would be the best for a consistent UX. We could of course do it differently for SFB versus catalog. Relevant recent discussion about the same topic here: datalad/datalad-catalog#266
Yeah I don't think users would use this feature a lot, I agree it can be made less prominent. Catalog issue: datalad/datalad-catalog#281
Thanks for catching. This needs to default to something standard, or the button should be hidden, if "about" content is not provided during catalog generation. Relevant catalog issue: datalad/datalad-catalog#270
@adswa I did the same and find nothing wrong with the metadata. To clarify, this is catalog metadata, not metalad-extracted metadata, and it therefore adheres to its own schema which could explain the unexpected "something seems to be odd". Or does this comment refer to something else?
Agreed. Catalog issue: datalad/datalad-catalog#282 |
I wonder how to do it best without breaking the paradigm. Probably translator indeed. We use studyminimeta as the source for the funding information, and there it's just text, no fields. I opened an issue in wackyextras - would be hestiant to add the same logic to the catalog's translator. mslw/datalad-wackyextra#2 |
CFF valid keys do not include anything that would correspond to funding. CFF has So the only "dataset metadata file" format we have for grants is studyminimeta. But we decided to use CFF for project superdatasets because it's a wider standard. We could drop in a studyminimeta file into all project datasets in addition (in the current catalog, funding info is merged, all things we care about have priorities). Studyminimeta file (if I understand correctly) has to have at least oone keyword. So through this we would also give everyone a keyword (probably "motor control"). Which may in fact be good in light of the comments about keywords made earlier. At this stage I wonder if I should worry about "breaking paradigm" (paradigm being that all metadata in the catalog needs to come from datasets through extraction and translation). I could, after all, for every project update add one more metadata item, that would contain funding information (metadata source: catalog curation)... |
I think breaking paradigm is fine for this specific goal. We're keeping track of everything, so that information will feed back into the process and inform updates. |
ah, I guess it just showed me "no metadata tags found" because there are so few. Thx :) |
The metadata I was referring to is in footnote 2 of the original post:
specifically all those "datacite_gin" values struck me as odd - e.g., "license" = "datacide_gin"? Can you make sense of it? |
That's still under "key_source_map" key. To enable setting source priority for a given field (source names in preferred order, in catalog config), the metadata source is stored in the catalog. If that is the only metadata, I would worry though ;) |
Oh man, thanks for clarifying :) 🤦 |
@mih It's easy to show the publications if other tabs are empty, but I'm not sure what would be the best for a consistent UX. We could of course do it differently for SFB versus catalog. Relevant recent discussion about the same topic here: datalad/datalad-catalog#266 |
I went through the list and ticked the boxes that no longer reply (although I didn't try to pinpoint specific changes that introduced them). Of note, (not) displaying the empty subdatasets page has seen changes that were ultimately reverted in the catalog, so the comment above is still valid. I am closing this issue as resolved. |
This is an unordered listing of nitpicks from the group chat:
<scp>
tags in C03 -- IIRC they came from Crossref, probably can be stripped by the metadata translator(1) quoting @mih: Conceptually we cannot propagate the subdataset name in the superdataset to that page (the page is the same regardless of how many different names this datasets has in different superdatasets). So the choice needs to be made elsewhere, but it must be made. Likely the title metadata source should be different or a composite
(2)
"key_source_map": {"name": ["datacite_gin"], "description": ["datacite_gin"], "license": ["datacite_gin"], "authors": ["datacite_gin"], "keywords": ["datacite_gin"], "type": ["metalad_core"], "dataset_id": ["metalad_core"], "dataset_version": ["metalad_core"], "url": ["metalad_core"]}, "sources": [{"source_name": "datacite_gin", "source_version": "0.0.1", "source_parameter": {}, "source_time": 1681234618.8610961, "agent_email": "[email protected]", "agent_name": "Micha\u0142 Szczepanik"}
The text was updated successfully, but these errors were encountered: