-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NF: add number of subdatasets to dataset view and on each item in subdatasets tab #280
Comments
This will require a change with costs that we likely do not want to incur. Currently the following happens when entering a dataset page:
With this process, we can count the number of subdatasets (both available and unavailable in the catalog). Note: I think it would make sense from a UX perspective to display the number of available datasets (not the total). BUT, if we also want to display the number of subdatasets of each subdataset (i.e. in the list of subdatasets where we currently display subdataset name, authors, keywords, etc) we will have to recurse into subsubdatasets at step 2 above, and this might introduce unwanted delays, i.e. wait for info on a dataset page to load just because one of its subdatasets has a thousand subdatasets. So unless we want to implement something else to achieve the same (e.g. run some service that routinely checks subsubdatasets and updates the number on all dataset entries correctly) I think we should not add the subsubdataset count. However, showing the subdataset count of the current dataset is feasible, e.g.: |
It sounds like this is not worth the investment. I am not familiar enough with the processing logic, but it seems to make sense that such a "reach-down" would break encapsulation and make things more complicated. |
I agree |
So that:
The text was updated successfully, but these errors were encountered: