-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: disable tabs with no content #266
Comments
This is proving to be more difficult than anticipated. It somehow relates to the asynchronous call made upon navigation to the dataset page, in order to get subdatasets or files. |
(Note: standard tabs are The options for tab display are: 1 - Always display standard tabsIf they don't have content, display a message stating that. This is the current setting 2 - Disable standard tabs with no contentE.g. if the 3 - Hide standard tabs with no contentE.g. if the Which UX would you expect or prefer? |
I would prefer option 2. It is consistent with a number of user interfaces that allow the "familiar" click, but state explicitly that there is no data. I also think that not being able to click on a tab on which you usually click out of habit feels wrong. |
@christian-monch Do you mean option 1? Option 2 is the one that does not allow the click. |
I lean towards option 1 or 3, with a slight preference for option 3.
I understand why you like the idea of a consistent user experience, and I do like option 1 over 2. But the empty tabs makes me feel like it's incomplete/not done when that might not be the case. |
Ok based on feedback I am leaning towards option 1 (which is also technically much easier) |
Closing since nothing further needs to be done. Decided on Option 1 and this does not require changes. |
It is not clear to me why there are "standard tabs" and "non-standard" tabs? From a user perspective this seems to be an arbitrary and opaque distinction, but it is used here to explain behavior differences. |
IMO there's always an expected structure for what a dataset looks like in a user interface. If you click on a dataset in any portal-like interface, there's always some top-level description and then options to view other properties of the dataset (in our case subdatasets, file tree, publications etc.). Some of these properties might be shown by default, and others would need to be selected in order to be rendered. IMO the position and availability of these options, and the way a user interacts with them, should be predictable. If you click on one dataset and only see publications (no other tabs), and on another dataset and see three tabs with one autorendered, how do you discern which dataset actually has which content? Is it existing but hidden for some reason, or missing, or non-existent? To make these questions unnecessary, i.e. to make the UX as intuitive as possible, I think the setup of the tabs and their content should be predictable and standard across datasets in the catalog. |
Closing this since the current state in main is sufficient to address this issue. |
e.g.:
"subdatasets" tab can be disabled if no content is available to display, and the "files" tab would therefore be the default displayed tab in this case.
IMO the empty tabs should not be hidden/removed, since this would make for an inconsistent user experience. Better to keep the components where they are expected to be, but make it clearer/intuitive when they cannot be interacted with.
The text was updated successfully, but these errors were encountered: