Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temp Folder Security #78

Closed
sevensolutions opened this issue Oct 23, 2024 · 2 comments
Closed

Temp Folder Security #78

sevensolutions opened this issue Oct 23, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@sevensolutions
Copy link
Owner

The temp folder is shared across all allocations. Maybe it would be a good idea to create special subfolders for each allocation (maybe even within the alloc dir) and only permit the own app.

Sidenote: When using the dump request of the management API it will also temporarily write the dumps to the temp directory which could be a security risk.

@sevensolutions sevensolutions added the enhancement New feature or request label Oct 23, 2024
@sevensolutions
Copy link
Owner Author

sevensolutions added a commit that referenced this issue Oct 26, 2024
@sevensolutions
Copy link
Owner Author

195926a fixes two things:

  1. We've applied too much environment variables on the app pool. Some of them did belong to the nomad_iis process itself, not to the user's job.
  2. I'am now overwriting the TMP and TEMP variables to use the alloc-dir's "tmp" folder, because it seems to be prepared for this usecase. See: https://developer.hashicorp.com/nomad/docs/concepts/filesystem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant