Make the writer even more unsafe. #1830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gankra
reviewed
Oct 6, 2017
webrender_api/src/display_list.rs
Outdated
| @@ -523,7 +521,11 @@ fn serialize_fast<T: Serialize>(vec: &mut Vec<u8>, e: &T) { | |||
| bincode::serialize_into(&mut size,e , bincode::Infinite).unwrap(); | |||
| vec.reserve(size.0); | |||
|
|
|||
| bincode::serialize_into(&mut UnsafeVecWriter(vec), e, bincode::Infinite).unwrap(); | |||
| let old_len = vec.len(); | |||
| let ptr = unsafe { vec.as_mut_ptr().offset(vec.len() as isize) }; | |||
There was a problem hiding this comment.
r=me with this changed to old_len
jrmuizel
force-pushed
the
even-more-unsafe
branch
from
43705c1
to
eaa5d63
Compare
|
I fixed up old_len and added a debug_assert to make sure things are sane. |
Instead of changing the length every write we just adjust the pointer. This avoids rust-lang/rust#45068. However we now need to ensure that we set the length when we are done. With this patch only 1.2% of WebRender display list building is spent in serialization.
|
With this patch only 1.2% of WebRender display list building is spent in serialization. |
jrmuizel
force-pushed
the
even-more-unsafe
branch
from
eaa5d63
to
94e88a5
Compare
|
Nice! |
|
What was the fraction of time spent in serialization before? |
|
I have too few samples to get a good comparison of the unsafe serializers. We have some patches coming that get rid of the cpu time spent elsewhere so that should raise the percentage of time spent in serialization. The safe serializer accounted for roughly 5.1% of the display list construction time. |
|
r=me, don't have review rights yet |
|
@bors-servo r=Gankro |
|
📌 Commit 94e88a5 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Oct 8, 2017
Make the writer even more unsafe. Instead of changing the length every write we just adjust the pointer. This avoids rust-lang/rust#45068. However we now need to ensure that we set the length when we are done. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1830) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Oct 9, 2017
glennw
pushed a commit
to glennw/saltfs
that referenced
this pull request
Oct 20, 2017
Some reviews in WR that Gankro has worked on: servo/webrender#1830 servo/webrender#1799 servo/webrender#1834 servo/webrender#1664
bors-servo
pushed a commit
to servo/saltfs
that referenced
this pull request
Oct 20, 2017
Add Gankro to WR reviewers list. Some reviews in WR that Gankro has worked on: servo/webrender#1830 servo/webrender#1799 servo/webrender#1834 servo/webrender#1664 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/740) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of changing the length every write we just adjust the pointer.
This avoids rust-lang/rust#45068.
However we now need to ensure that we set the length when we are done.
This change is