Use an unsafe serializer. #1799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @gankro |
dtolnay
suggested changes
Oct 3, 2017
There was a problem hiding this comment.
Nicely done!
Please document more clearly what makes this unsafe. By using this implementation, we are trusting all of the Serialize impls that it ever serializes. I can break the trust with a Serialize like this:
struct S {
first: Cell<bool>,
}
impl Serialize for S {
fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
where S: Serializer
{
if self.first.get() {
self.first.set(false);
().serialize(serializer)
} else {
0.serialize(serializer)
}
}
}
|
I'm currently building a rustc with the noalias flag we discussed, would like to hold off on merging that until we've looked at the codegen of the 4 combos of |
Gankra
reviewed
Oct 3, 2017
webrender_api/src/display_list.rs
Outdated
| @@ -483,6 +485,48 @@ impl<'a, 'b> Serialize for DisplayItemRef<'a, 'b> { | |||
| } | |||
| } | |||
|
|
|||
| // This is a replacement for bincode::serialize_into(&vec) | |||
| // The default implementation Write for Vec will basically | |||
| // call extend_from_slice(). Serde ends up calling that for ever | |||
|
Some codgen tests here. Looks like this is an all around win, and even positions us for bigger wins with mutable noalias: |
jrmuizel
force-pushed
the
unsafe-serialize
branch
from
a0437c7
to
2bbdbb7
Compare
|
@bors-servo r+ |
|
@gankro: 🔑 Insufficient privileges: Not in reviewers |
This gives a noticable impact on serialization performance in Gecko. wr_dp_push_text() goes from 35.6% of nsDisplayText::CreateWebRenderCommands down to 24%. The generated code is still pretty bad but hopefully adding proper noalias information to rust will fix that.
jrmuizel
force-pushed
the
unsafe-serialize
branch
from
2bbdbb7
to
214a48c
Compare
kvark
approved these changes
Oct 4, 2017
| fn serialize_fast<T: Serialize>(vec: &mut Vec<u8>, e: &T) { | ||
| // manually counting the size is faster than vec.reserve(bincode::serialized_size(&e) as usize) for some reason | ||
| let mut size = SizeCounter(0); | ||
| bincode::serialize_into(&mut size,e , bincode::Infinite).unwrap(); |
webrender_api/src/display_list.rs
Outdated
| unsafe { | ||
| let old_len = self.0.len(); | ||
| self.0.set_len(old_len + buf.len()); | ||
| ptr::copy_nonoverlapping(buf.as_ptr(), self.0.as_mut_ptr().offset(old_len as isize), buf.len()); |
There was a problem hiding this comment.
need some debug assertions for the capacity guarantee
|
@bors-servo r=Gankro,kvark |
|
📌 Commit 214a48c has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Oct 4, 2017
Use an unsafe serializer. This gives a noticable impact on serialization performance in Gecko. wr_dp_push_text() goes from 35.6% of nsDisplayText::CreateWebRenderCommands down to 24%. The generated code is still pretty bad but hopefully adding proper noalias information to rust will fix that. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1799) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-travis |
glennw
pushed a commit
to glennw/saltfs
that referenced
this pull request
Oct 20, 2017
Some reviews in WR that Gankro has worked on: servo/webrender#1830 servo/webrender#1799 servo/webrender#1834 servo/webrender#1664
bors-servo
pushed a commit
to servo/saltfs
that referenced
this pull request
Oct 20, 2017
Add Gankro to WR reviewers list. Some reviews in WR that Gankro has worked on: servo/webrender#1830 servo/webrender#1799 servo/webrender#1834 servo/webrender#1664 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/740) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives a noticable impact on serialization performance in Gecko.
wr_dp_push_text() goes from 35.6% of
nsDisplayText::CreateWebRenderCommands down to 24%.
The generated code is still pretty bad but hopefully adding
proper noalias information to rust will fix that.
This change is