Ignore UTS46 validity criteria V2 #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canova
force-pushed
the
idna
branch
2 times, most recently
from
66d4f1e to
7a11639
Compare
Manishearth
reviewed
Nov 18, 2016
| (third, fourth) == (Some('-'), Some('-')) | ||
| } || label.starts_with("-") | ||
| // Spec says, the label must not contain a HYPHEN-MINUS character in both the | ||
| // third and fourth positions. But nobody follow this criteria. See the spec issue below: |
There was a problem hiding this comment.
"Spec says that the", and "follows"
|
LGTM but I would like sign-off from @SimonSapin here |
Manishearth
reviewed
Nov 18, 2016
| let fourth = chars.next(); | ||
| (third, fourth) == (Some('-'), Some('-')) | ||
| } || label.starts_with("-") | ||
| // Spec says that the, label must not contain a HYPHEN-MINUS character in both the |
|
Isn't this the same as #208? If so, it's really sad that that PR has been sitting there for so long :( |
|
It removes the configurability. |
|
Fixed the typo |
|
r? @SimonSapin |
|
@bors-servo r+ Thanks! |
|
📌 Commit 695a507 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 22, 2016
Ignore UTS46 validity criteria V2 Fixes #160 r? @SimonSapin or @Manishearth <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/240) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #160
r? @SimonSapin or @Manishearth
This change is