Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider ignoring UTS46 validity criteria V2 #160

Closed
valenting opened this issue Jan 23, 2016 · 7 comments
Closed

Consider ignoring UTS46 validity criteria V2 #160

valenting opened this issue Jan 23, 2016 · 7 comments

Comments

@valenting
Copy link
Collaborator

Each of the following criteria must be satisfied for a label:
2. The label must not contain a U+002D HYPHEN-MINUS character in both the third and fourth positions. 

However, it seems that other UAs don't enforce this, and it matches domains commonly used on youtube. ex: r6---sn-5hne6nee.googlevideo.com

@SimonSapin
Copy link
Member

In that case, UTS-46 should probably be changed to match reality. It says:

Please submit corrigenda and other comments with the online reporting form [Feedback].

so please do that. But since Unicode doesn’t have a public bug tracker, it’d be good to also track it in whatwg/url#53.

@valenting
Copy link
Collaborator Author

Just to note, I raised the issue using the reporting form, and they took note of the offending URLs such as http://r6---sn-5hne6nee.googlevideo.com

The rule is only included because the IETF wanted to reserve labels of the form XX--... for future use, in case they wanted another signature like "xn--"

They will probably address this in the June release of the next version.

@Manishearth
Copy link
Member

I think we should make accepting this behavior an option in ParseOptions.

@canaltinova want to try working on this? see #207 for more context

@canova
Copy link

canova commented Nov 18, 2016

Sure, I can give it a try :)

@SimonSapin
Copy link
Member

I'm convinced it's worth an option. If nobody follows a spec on some detail, it's a spec bug and we should just align with other implementation.

bors-servo pushed a commit that referenced this issue Nov 22, 2016
Ignore UTS46 validity criteria V2

Fixes #160
r? @SimonSapin or @Manishearth

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/240)
<!-- Reviewable:end -->
@thomcc
Copy link

thomcc commented May 31, 2019

Did this ever get an option? Currently (I think?) hitting this in mozilla-mobile/fenix#2994

@SimonSapin
Copy link
Member

I don’t remember any of the details, but this issue is marked as closed by #240.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants