Add Pictures faker #254
Merged
Add Pictures faker #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serpro69
added
enhancement 🚀
serpro69
force-pushed
the
uifaces_avatars
branch
from
bbf4605 to
e62dcb4
Compare
Closed
Closed
|
|
vanniktech
reviewed
Nov 17, 2024
faker/pictures/src/main/kotlin/io/github/serpro69/kfaker/pictures/provider/UiFaces.kt
Outdated
Show resolved
Hide resolved
Yeah, I'm leaning towards that also 👍 As a user, I'd rather not have network calls for such functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very simple implementation for #251 . Obviously does not support multiplatform as-is, but should be simple enough to implement each target once faker itself supports multiplatform.
Still not sure if it's better to fetch data from a remote location, or have all the pictures as part of an artifact. Both have their pros and cons of course... Also, how to test this in a good way?