Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random Profile Picture #251

Closed
vanniktech opened this issue Oct 27, 2024 · 8 comments · Fixed by #254
Closed

Random Profile Picture #251

vanniktech opened this issue Oct 27, 2024 · 8 comments · Fixed by #254
Labels
enhancement 🚀 New feature or request faker 💯 Issue related to :faker modules good first issue 🔰 Good for newcomers
Milestone

Comments

@vanniktech
Copy link

Would be nice if the Person in addition to the birthDate also has a way to obtain a profile picture ideally also with male/female/neutral just like we can do when generating names.

@serpro69
Copy link
Owner

Hi @vanniktech ,
Thanks for the suggestion, sounds like a valid use-case, but would like some more details.

  • Do you want to return a file, a link to a file, or something else?
  • Are you thinking of an array of pics for each type, or just one picture per type?
    • If we want an array of pictures, do you have any suggestions on where to source the data from? This likely needs to be some open third-party source with fake profile pics or something similar.

@vanniktech
Copy link
Author

With consideration of #226 the best might to just to get a ByteArray of an image with 32bit RGBA values?

Ideally, different pictures. Regarding the source, I don't have one in mind.

@serpro69
Copy link
Owner

With consideration of #226 the best might to just to get a ByteArray of an image with 32bit RGBA values?

Good point.

I also don't know where one would be able to get pics that can be used for this, considering all sorts of things like privacy etc on top of it.
But I'll try to research a bit.
Feel free to update with more details if you come up with something.

@serpro69 serpro69 added this to the 2.0.0 milestone Oct 28, 2024
@serpro69 serpro69 added enhancement 🚀 New feature or request core 🧬 Issue related to :core module good first issue 🔰 Good for newcomers labels Oct 28, 2024
@vanniktech
Copy link
Author

https://uifaces.co/ this is as close as I've gotten when I took some time today to find some pictures.

@serpro69
Copy link
Owner

Good find, @vanniktech , thanks!
I've downloaded all the avatars and pushed them to a separate repo for now - https://github.com/serpro69/uifaces-ai-avatars
I'm not sure yet if I want to fetch and read avatars from remote location, or include as part of the jar. With the latter, I'd probably use a separate module, so that the size of the core module jar isn't needlessly increased.

Would you like to submit a PR for this? Otherwise I can take a look at implementing it myself.

@vanniktech
Copy link
Author

Would you like to submit a PR for this? Otherwise I can take a look at implementing it myself.

I'm currently traveling so I have limited time. Doing it in a separate module sounds perfect!

@serpro69 serpro69 linked a pull request Nov 16, 2024 that will close this issue
@serpro69
Copy link
Owner

Did some very simple implementation in #254 . Feel free to take a look and provide some feedback, if you like ;)

@serpro69 serpro69 added faker 💯 Issue related to :faker modules and removed core 🧬 Issue related to :core module labels Nov 16, 2024
@serpro69
Copy link
Owner

Should be available in the latest 2.1.0-SNAPSHOT version once the build is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🚀 New feature or request faker 💯 Issue related to :faker modules good first issue 🔰 Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants