Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the compatibility of label routing when upgrading from 1.0-1.3 #1424

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

provenceee
Copy link
Collaborator

@provenceee provenceee commented Jan 22, 2024

【Fix issue】 #1406

[Modification content] Modified the incompatibility issue introduced by label routing when upgrading from 1.0-1.3. For specific modification points, please view the issue

[Self-test situation] Local self-test passed, ut test passed

[Scope of influence] No impact

Signed-off-by: provenceee <[email protected]>
@provenceee provenceee added kind/enhancement Issues or PRs releated to sermant enhancement area/plugin Issues or PRs releated to sermant plugin service labels Jan 22, 2024
@provenceee provenceee self-assigned this Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 67 lines in your changes are missing coverage. Please review.

Comparison is base (a1fed04) 42.73% compared to head (e6d4269) 43.37%.

Files Patch % Lines
...eicloud/sermant/router/config/utils/RuleUtils.java 46.66% 12 Missing and 4 partials ⚠️
...d/sermant/router/config/service/ConfigService.java 0.00% 16 Missing ⚠️
...outer/config/handler/kind/AbstractKindHandler.java 85.86% 5 Missing and 8 partials ⚠️
...oud/sermant/router/common/config/RouterConfig.java 0.00% 6 Missing ⚠️
...mant/router/config/entity/RouterConfiguration.java 84.37% 2 Missing and 3 partials ⚠️
...t/router/config/listener/RouterConfigListener.java 0.00% 5 Missing ⚠️
...ant/router/config/handler/GlobalConfigHandler.java 0.00% 0 Missing and 1 partial ⚠️
...ant/router/config/handler/RouterConfigHandler.java 0.00% 0 Missing and 1 partial ⚠️
...nt/router/config/handler/ServiceConfigHandler.java 0.00% 0 Missing and 1 partial ⚠️
...nt/router/config/handler/kind/FlowKindHandler.java 85.71% 0 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1424      +/-   ##
=============================================
+ Coverage      42.73%   43.37%   +0.64%     
- Complexity      3349     3422      +73     
=============================================
  Files            843      847       +4     
  Lines          18682    18857     +175     
  Branches        2061     2084      +23     
=============================================
+ Hits            7984     8180     +196     
+ Misses          9704     9645      -59     
- Partials         994     1032      +38     
Flag Coverage Δ
unittests 43.37% <67.78%> (+0.64%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sherlockhan Sherlockhan merged commit 6f1b831 into sermant-io:develop Jan 27, 2024
64 checks passed
@kkf1 kkf1 changed the title 修改1.0-1.3升级时,标签路由的兼容性 Modify the compatibility of label routing when upgrading from 1.0-1.3 Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin Issues or PRs releated to sermant plugin service kind/enhancement Issues or PRs releated to sermant enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants