Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible upgrades in 1.0-1.3 #1406

Closed
provenceee opened this issue Jan 9, 2024 · 1 comment
Closed

Incompatible upgrades in 1.0-1.3 #1406

provenceee opened this issue Jan 9, 2024 · 1 comment
Assignees
Labels
area/plugin Issues or PRs releated to sermant plugin service kind/enhancement Issues or PRs releated to sermant enhancement

Comments

@provenceee
Copy link
Collaborator

provenceee commented Jan 9, 2024

What would you like to be enhanced?

Fix compatibility between 1.0-1.3

Why is this needed?

Increase compatibility

@provenceee provenceee added kind/enhancement Issues or PRs releated to sermant enhancement area/plugin Issues or PRs releated to sermant plugin service labels Jan 9, 2024
@provenceee provenceee self-assigned this Jan 9, 2024
@provenceee
Copy link
Collaborator Author

provenceee commented Jan 17, 2024

There are 2 incompatibilities in 1.0-1.3

  1. The label routing rules are incompatible. To address this point, modify it as follows:
    For global routing rules (servicecomb.globalRouteRule) and service-level routing rules (servicecomb.routeRule), when the rules contain routematcher.sermant.io/flow routematcher.sermant.io/tag route.sermant.io/lane, the new format is used Parse, otherwise use the old format to parse, and then encapsulate it into the configuration cache class according to the format; for the rules of routematcher.sermant.io/tag route.sermant.io/lane, servicecomb.tagRule/servicecomb.laneRule (service level) is added , servicecomb.globalTagRule/servicecomb.globalLaneRule (global) is processed, and the configuration content is consistent with the rules node content in the original rules.

  2. AZ affinity routing is incompatible. For this point, the modification is as follows:
    It is necessary to add the configuration in version 1.0 (enabled-dubbo-zone-router enabled-spring-zone-router) to 1.3. When the configuration is enabled and the configuration center does not configure a tag-matching route, the same tag matching of the new zone tag will be added. Route to default configuration

1.0-1.3存在2点不兼容

  1. 标签路由规则不兼容,针对该点,修改如下:
    对于全局路由规则(servicecomb.globalRouteRule)和服务级路由规则(servicecomb.routeRule),当规则中含有routematcher.sermant.io/flow routematcher.sermant.io/tag route.sermant.io/lane时,用新格式解析,否则用老格式解析,然后按格式封装到配置缓存类中;对于routematcher.sermant.io/tag route.sermant.io/lane的规则,新增了servicecomb.tagRule/servicecomb.laneRule(服务级),servicecomb.globalTagRule/servicecomb.globalLaneRule(全局)进行处理,配置内容与原规则中rules节点内容一致

  2. az亲和路由不兼容,针对该点,修改如下:
    需要增加1.0版本中的配置(enabled-dubbo-zone-router enabled-spring-zone-router)到1.3中,当开启配置,且配置中心没有配置tag匹配的路由时,新增zone标签的同标签匹配路由到默认配置中

@hanbingleixue hanbingleixue reopened this Jan 18, 2024
@kkf1 kkf1 changed the title 1.0-1.3存在不兼容的升级 There are incompatible upgrades in 1.0-1.3 Apr 13, 2024
@kkf1 kkf1 changed the title There are incompatible upgrades in 1.0-1.3 Incompatible upgrades in 1.0-1.3 Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin Issues or PRs releated to sermant plugin service kind/enhancement Issues or PRs releated to sermant enhancement
Projects
None yet
Development

No branches or pull requests

2 participants