Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update System.Net.Http references #78

Merged
merged 1 commit into from
Dec 12, 2017

Conversation

Blackbaud-JeffDye
Copy link
Contributor

Addresses #77
Based off of the changes in datalust/serilog-sinks-seq#85

I haven't modified references like this before so please check over all this thoroughly, there might be something that I've missed or failed to account for.

Also, I needed to update xunit and xunit.runner.visualstudio to 2.3.1 in order to run tests locally, not sure if that's due to using latest Visual Studio and/or .Net 4.7.1 - I've held off on pushing that commit, but I can if it isn't an issue for y'all.

Thanks!

@Blackbaud-JeffDye
Copy link
Contributor Author

Really sorry to bother you while you're out on holiday @merbla, if it isn't too much trouble to check this out whenever you have a second? Perhaps @nblumhardt could give these changes a quick sanity check as he's the author of the changes in serilog-sinks-seq that I based these off of?

Thanks guys!

@nblumhardt
Copy link
Contributor

@Blackbaud-JeffDye thanks for the PR! @merbla I think since this is going into dev it's a good opportunity to vet the changes - LGTM, I'll hit the button and beg forgiveness if this all goes horribly wrong ;-)

@nblumhardt nblumhardt merged commit 2bc05b2 into serilog-contrib:dev Dec 12, 2017
@Blackbaud-JeffDye Blackbaud-JeffDye deleted the http-versions branch December 13, 2017 15:06
@merbla merbla mentioned this pull request Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants