Change how System.Net.Http is referenced #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated to also address #83. |
…ramework test platforms
nblumhardt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under the assumption that it's likely anyone using the latest Seq sink will also be using the latest System.Net.Http.
Edit
This PR now completely separates how System.Net.Http is referenced; on the full framework targets, the assembly is referenced, while on .NET Core/Standard the package is referenced. As long as client apps follow this scheme, everything should "just work" TM. This is preferred to the current scheme, because it avoids the chance of creating impossible-to-resolve dependency constraints (see #73, #83).
There's a risk this will break clients who don't follow this scheme; we'll need to test the pre-release package pretty heavily to make sure these breakages are easily detectable and fixable.