This repository has been archived by the owner on Jun 1, 2024. It is now read-only.
Format stacktrace as array #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sticsearch into format-stacktrace-as-array
|
Looks like there is a merge conflict. Can you resolve that one? |
|
I think your branch contains more commits than your intended change. |
|
Sorry about that @mivano I hadn't merged the dev branch into mine |
|
It's also would be nice to correct comments for ElasticsearchJsonFormatter constructor
|
|
The Serilog.Sinks.Elasticsearch.7.2.0-alpha0004 package should contain this latest code. Let me know if this was sufficient, then I can create the final package from master. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this PR address?
Fix #232
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Other information: