Skip to content
This repository has been archived by the owner on Jun 1, 2024. It is now read-only.

Bug in stack trace as array of strings #232

Closed
AceHack opened this issue Apr 9, 2019 · 3 comments · Fixed by #233
Closed

Bug in stack trace as array of strings #232

AceHack opened this issue Apr 9, 2019 · 3 comments · Fixed by #233

Comments

@AceHack
Copy link

AceHack commented Apr 9, 2019

https://github.com/serilog/serilog-sinks-elasticsearch/blob/f9f80778c743ea2f1d8c7eb008f171a6ed59ad28/src/Serilog.Formatting.Elasticsearch/ExceptionAsObjectJsonFormatter.cs#L54

The formatStackTraceAsArray parameter is passed to the base classes renderMessageTemplate parameter
@mivano
Copy link
Contributor

mivano commented Apr 9, 2019

@oscarmorasu I think a recent change by you? Would you mind to have a look?

@oscarmorasu
Copy link
Contributor

oscarmorasu commented Apr 9, 2019 •
edited
Loading

Thanks for the heads up @AceHack . @mivano can you please check the PR and merge it?

oscarmorasu pushed a commit to oscarmorasu/serilog-sinks-elasticsearch that referenced this issue Apr 9, 2019
Fix serilog-contrib#232 Pass flag formatStackTraceAsArray to base class
4cf1486
@oscarmorasu oscarmorasu mentioned this issue Apr 9, 2019
Merged
1 task
mivano pushed a commit that referenced this issue Apr 14, 2019
@oscarmorasu @mivano
Format stacktrace as array (#233)
2750db4 
* Github releases added to yaml

* Create new release

* fix title of changelog (#211)

* Added FormatStackTraceAsArray option to write StackTrace as an array

* Added unit tests, minor code-style changes

* Fix #232 Pass flag formatStackTraceAsArray to base class

* Fix propertuy comment
@mivano
Copy link
Contributor

mivano commented Apr 14, 2019

Done, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Format stacktrace as array oscarmorasu/serilog-sinks-elasticsearch
3 participants
@AceHack @mivano @oscarmorasu