Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatibility updates for sequelize >=6.2 #856

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

lukashroch
Copy link
Collaborator

@lukashroch lukashroch commented Nov 13, 2020

Types compatibility updates for sequelize >=6.2

  • Build OK
  • Tests OK

This updates type changes introduced in sequelize >=6.2 (https://github.com/sequelize/sequelize/commit/871157bc07ccdbf2445581b8becd297ede887c22)

@lukashroch lukashroch changed the title compatibility updates for sequelize ^6.2 compatibility updates for sequelize >=6.2 Nov 17, 2020
@goalia
Copy link

goalia commented Nov 25, 2020

Pleaseeeeeeeeee @RobinBuschmann 🐒🙏🏼

@niloyc
Copy link

niloyc commented Nov 26, 2020

@RobinBuschmann please merge if all ok...

@lukashroch
Copy link
Collaborator Author

@RobinBuschmann can you merge for next beta to let people test?

If all OK, happy to prepare PR to update README to reflect new sequelize changes and probably remote old-style scopes. They were already deprecated since v1, so I think it could be removed for v2 and sequelize v6.

@paolocattani
Copy link

@RobinBuschmann are you still following this project? Have you considered transfer ownership to someone?
Lots of nice guys are trying to keep this project updated.

@goalia
Copy link

goalia commented Nov 27, 2020

@kamilmysliwiec @BrunnerLivio @fwoelffel @jmcdo29 @johnbiundo @MarkPieszak @nartc @thomrick @valorkin Hello guys 👋🏼 Do you think about a fork of this project ? This package it's a big part of a good integration between NestJs and Sequelize for typescript usage 🧐 I think @RobinBuschmann no longer follows this project 🤔 There is no release since this summer (moreover it's a beta). 😞

@niloyc
Copy link

niloyc commented Dec 3, 2020

@paolocattani @Benjamin-Gardien I think he is still active in github, I tried reaching out through another repo...

@RobinBuschmann RobinBuschmann merged commit 7e77fc1 into sequelize:master Dec 7, 2020
@goalia
Copy link

goalia commented Dec 7, 2020

@RobinBuschmann thank you 🎉

@RobinBuschmann
Copy link
Member

RobinBuschmann commented Dec 7, 2020

Sorry guys, this year was a really tough one for me and I'm afraid I won't have much time in the near future. But I'm still highly interested in keeping this project up. So help is very much appreciated. I would really like to add collaborators to this project. If anyone is interested and can show some references to open-source projects..? I know that collaborators won't be enough, since sequelize-typescript runs under my npm account. So that the release process requires to be automated via github as well.

@RobinBuschmann
Copy link
Member

I've just released a new beta... also available with @next: [email protected] Any feedback would be very nice

Thank you @lukashroch very much for implementing. Nice work 👍

@goalia
Copy link

goalia commented Dec 7, 2020

@QuanticPotatoes and me are interested to help you to maintain this project but we don't really have experience in Open source projet 😞 Only @QuanticPotatoes participated 3 years ago to an open source project. Usually, we built application for private company 🤷🏼‍♂️ Maybe it's time for us to try ! It will be a pleasure to try to help you 😃

@luiz290788
Copy link

@QuanticPotatoes and me are interested to help you to maintain this project but we don't really have experience in Open source projet 😞 Only @QuanticPotatoes participated 3 years ago to an open source project. Usually, we built application for private company 🤷🏼‍♂️ Maybe it's time for us to try ! It will be a pleasure to try to help you 😃

I'm also interested. I have a little of experience with open source but we are really interested in helping in the project.

@RobinBuschmann
Copy link
Member

@goalia @luiz290788 thanks. I think any advanced contributions to this project would be a good reference :)

@lukashroch, what about you? Are you interested in being added as a collaborator to this project?

@goalia
Copy link

goalia commented Jan 17, 2021

@RobinBuschmann maybe we can make a call with @luiz290788 and @lukashroch and also with my co founder @QuanticPotatoes ? 😊

@lukashroch
Copy link
Collaborator Author

@RobinBuschmann sure, happy to help out! 👍

ehavet pushed a commit to ehavet/falco that referenced this pull request Feb 25, 2022
[TECH] Upgrade sequelize, sequelize-cli and sequelize-typescript

Upgrade details : 

- Sequelize: 5.21.12 => 6.3.5 with breaking change release (https://github.com/sequelize/sequelize/releases/tag/v6.1.0). Looking at the release note we are only impacted with one change from v6 (`addConstraint` method in migrations that now take only 2 parameters instead of 3).

- Sequelize-cli: 5.5.1 => 6.2.0 (https://github.com/sequelize/cli/releases/tag/v6.0.0 https://github.com/sequelize/cli/releases/tag/v6.1.0 https://github.com/sequelize/sequelize/releases/tag/v6.2.0)

- Sequelize-typescript: 1.1.0 => 2.0.0-beta.1 (sequelize/sequelize-typescript#807 and sequelize/sequelize-typescript#856

#8

See merge request appenin/falco-api!145
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants