Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how long to start support v6 #34

Closed
fish0373 opened this issue Oct 30, 2020 · 22 comments · Fixed by #39 or #41
Closed

how long to start support v6 #34

fish0373 opened this issue Oct 30, 2020 · 22 comments · Fixed by #39 or #41
Assignees
Labels
enhancement New feature or request

Comments

@fish0373
Copy link

how long to start support v6

@hsluoyz
Copy link
Member

hsluoyz commented Oct 30, 2020

@nodece @stu01509

@stu01509
Copy link

Hi @fish0373

Did you mean the npm package.js sequelize version?
If so I will create the PR to upgrade that.

@fish0373
Copy link
Author

yes, sequelize current version is v6
v5 is plan to deprecated
I wish this project can be support v6
thanks

@hsluoyz
Copy link
Member

hsluoyz commented Oct 30, 2020

@nodece @stu01509 please update it.

@hsluoyz
Copy link
Member

hsluoyz commented Dec 16, 2020

We had some previous work at: #35

And now we are resurrecting this issue.

@hsluoyz
Copy link
Member

hsluoyz commented Dec 17, 2020

@fish0373 Quote @zhmushan

We need to wait for "sequelize-typescript" to release 2.0.0

@hsluoyz hsluoyz closed this as completed Dec 17, 2020
@hsluoyz
Copy link
Member

hsluoyz commented Dec 17, 2020

@hsluoyz
Copy link
Member

hsluoyz commented Dec 17, 2020

Hope someone will take this issue: https://github.com/node-casbin/js-sequelize-adapter/issues/11

@fish0373
Copy link
Author

Thanks
But, when I update it, I got another problem.
It happened on function getQueryInterface.
My typescript version is 4.1.2.
maybe I need to enable some compiler options?

截圖 2020-12-28 上午10 17 09

@hsluoyz
Copy link
Member

hsluoyz commented Dec 28, 2020

@fish0373 which adapter repo did you use?

@fish0373
Copy link
Author

casbin 5.2.0
casbin-sequelize-adapter 2.1.0
sequelize 6.3.5

@hsluoyz
Copy link
Member

hsluoyz commented Dec 28, 2020

@hsluoyz hsluoyz reopened this Dec 28, 2020
@hsluoyz hsluoyz added the help wanted Extra attention is needed label Dec 28, 2020
@hsluoyz hsluoyz pinned this issue Dec 28, 2020
@fish0373
Copy link
Author

I try js-sequelize-adapter
but it not support typescript type casting
when I import then it make some problem
and I require it then type always is Any type

@nodece
Copy link
Contributor

nodece commented Dec 31, 2020

@fish0373 The library only supports sequelize 5.x, we will support sequelize 6.x in next version.

@hsluoyz
Copy link
Member

hsluoyz commented Jan 10, 2021

@fish0373

We can try latest sequelize-typescript 2.0.0-beta.1 (a month ago) with sequelize >=6.2, see: sequelize/sequelize-typescript#856

image

@hsluoyz
Copy link
Member

hsluoyz commented Jan 10, 2021

Some update: sequelize/sequelize-typescript#876

@hsluoyz
Copy link
Member

hsluoyz commented Jan 10, 2021

@divy9881 can you have a look at this?

@Yash-g17
Copy link
Contributor

Yash-g17 commented Apr 2, 2021

@hsluoyz @nodece i installed the new versions of "sequelize": "^6.6.2", "sequelize-typescript": "^2.1.0" ,
Then I ran the yarn test function, it first gave me a mysql error which i resolved by starting the mysql server on my local machine , now it expects me to have a database names casbin
can you please guide me through the testing phase of the changes I've made.

@hsluoyz
Copy link
Member

hsluoyz commented Apr 2, 2021

@nodece

@nodece
Copy link
Contributor

nodece commented Apr 4, 2021

@Yash-g17 you need to create a database named casbin in mysql tool database by create database casbin command.

@Yash-g17
Copy link
Contributor

Yash-g17 commented Apr 4, 2021

@nodece Thanks , that worked
Creating a pull request now

@hsluoyz
Copy link
Member

hsluoyz commented Apr 4, 2021

PR reverted for: #39 (comment)

@hsluoyz hsluoyz unpinned this issue Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment