Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] add namespace seqan3::align_cfg::detail #2033

Merged
merged 2 commits into from
Aug 14, 2020
Merged

[FIX] add namespace seqan3::align_cfg::detail #2033

merged 2 commits into from
Aug 14, 2020

Conversation

marehr
Copy link
Member

@marehr marehr commented Aug 14, 2020 •
edited
Loading

Blocks #2031 and #2020

@marehr marehr requested a review from eseiler August 14, 2020 10:55
@Irallia Irallia mentioned this pull request Aug 14, 2020
Merged
@marehr marehr changed the title [DOC] add namespace seqan3::align_cfg::detail [FIX] add namespace seqan3::align_cfg::detail Aug 14, 2020
@simonsasse simonsasse mentioned this pull request Aug 14, 2020
Merged
eseiler
eseiler approved these changes Aug 14, 2020
View reviewed changes
Copy link
Member

@eseiler eseiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing regarding documentation, otherwise LGTM

include/seqan3/alignment/configuration/all.hpp Outdated Show resolved Hide resolved
@eseiler eseiler requested review from a team and rrahn and removed request for a team August 14, 2020 11:45
rrahn
rrahn approved these changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@rrahn rrahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@codecov
Copy link

codecov bot commented Aug 14, 2020 •
edited
Loading

Codecov Report

Merging #2033 into release-3.0.2 will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           release-3.0.2    #2033   +/-   ##
==============================================
  Coverage          97.89%   97.89%           
==============================================
  Files                263      263           
  Lines               9879     9879           
==============================================
  Hits                9671     9671           
  Misses               208      208
Impacted Files Coverage Δ
...gnment/configuration/align_config_aligned_ends.hpp 100.00% <ø> (ø)
...qan3/alignment/configuration/align_config_band.hpp 100.00% <ø> (ø)
...n3/alignment/configuration/align_config_method.hpp 100.00% <ø> (ø)
...alignment/configuration/align_config_on_result.hpp 100.00% <ø> (ø)
...n3/alignment/configuration/align_config_result.hpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ada8b38...5b4726a. Read the comment docs.

@rrahn rrahn merged commit 89df8c8 into seqan:release-3.0.2 Aug 14, 2020
@marehr marehr deleted the align_cfg_detail_ns branch August 14, 2020 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eseiler eseiler eseiler approved these changes

@rrahn rrahn rrahn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marehr @rrahn @eseiler @Irallia