[Alignment Configuration] Rename align_cfg::alignment_result_capture to align_cfg::detail::result_type

[simonsasse]

Resolves seqan/product_backlog#183

This moves the alignment_result_capture to a new namespace seqan3::align_cfg::detail and then renames it to result_type.
I needed to specify the whole namespace path seqan3::detail::XX for most of the view files. This is due to the newly created seqan3::align_cfg::detail which had a name clash with seqan3::detail.

Merging this PR closes #2018 because it has the same intention.

Blocked by #2033

[joergi-w]

This is different from the other lines... I don't know what's the impact, but please consider to keep the existing style.

Suggested change

	result_type, //!\brief ID for the \ref seqan3::align_cfg::detail::result_type "result_type" option.
	result_type, //!< ID for the \ref seqan3::align_cfg::detail::result_type "result_type" option.

[joergi-w]

Attention: Here is detail code documentation in the user visible documentation!
@ second reviewer: Is it fine or should we avoid this? (how?)

[joergi-w]

Merging this PR closes #2018 because it has the same intention.

[joergi-w]

Looks good, just a small documentation error is left. I assign the second reviewer now.

[marehr]

@seqan/core We have now some redundant work #2020 they both worked around the ambiguous seqan3::detail, seqan3::align_cfg::detail namespace. I added PR #2033 to extract their common parts.

[rrahn]

At the end I will have a final sweep to check for consistency issues that might happen between the PRs. I already had one config on the align_cfg::detail namespace and adapted only the things locally and wanted to add the namespace at the end. I am wondering why this was now exposed to all configs? Anyhow, now it is done already. We should wait for this change (already approved) and then rebase all the configs on top of this.

[rrahn]

@simonsasse I am waiting on the rebase on #2020 before I review. So I can focus on the actual changes.

[codecov]

Codecov Report

Merging #2031 into release-3.0.2 will not change coverage.
The diff coverage is 100.00%.

@@              Coverage Diff               @@
##           release-3.0.2    #2031   +/-   ##
==============================================
  Coverage          97.91%   97.91%           
==============================================
  Files                263      263           
  Lines               9887     9887           
==============================================
  Hits                9681     9681           
  Misses               206      206           

Impacted Files	Coverage Δ
...e/seqan3/alignment/pairwise/detail/type_traits.hpp	100.00% <ø> (ø)
...qan3/alignment/pairwise/alignment_configurator.hpp	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c53fceb...686436d. Read the comment docs.

[rrahn]

Some general renaming, otherwise looks very good. Thank you

[simonsasse]

Thanks for the review @rrahn . I applied all the changes and also rebased on the latest version of the release branch because there where merge conflicts. On my machine tests pass 💻✅

[smehringer]

whats the state here?

[simonsasse]

If @marehr review counts as second review, its time for a merge I think :)

[smehringer]

@marehr anything to add? Otherwise I'll merge (or you if you see this).

[marehr]

I only waited on CI and forgot that I waited in CI 🙈 (I'm not accustomed to be second reviewer) xD