Add support for field selectors #2892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 18, 2019 15:42
Signed-off-by: Simon Plourde <[email protected]>
Signed-off-by: Simon Plourde <[email protected]>
|
CircleCI builds are just getting OOM... |
ccressent
approved these changes
Apr 24, 2019
Signed-off-by: Simon Plourde <[email protected]>
echlebek
approved these changes
Apr 24, 2019
echlebek
added a commit
that referenced
this pull request
Apr 25, 2019
* Create 5.6.0 release branch Signed-off-by: Eric Chlebek <[email protected]> * Bugfix for annotations & labels flags (#2881) Signed-off-by: Simon Plourde <[email protected]> * Move dashboard source code into its own repository (#2869) As our project has grown, build targets increased, and time has passed, the ideal of a monorepo housing both the web and backend has simply caused more friction than it has reduced. Today we are moving Sensu Go Web into it's own repository: sensu/web. Signed-off-by: James Phillips <[email protected]> * [GraphQL] Ensures that all types are registered (#2875) Types that are not directly referenced by the root Schema type or any of their children are not immediately registered with the schema. As such to ensure that ALL types are available we append any that are missing. Signed-off-by: James Phillips <[email protected]> * Add message bus to tessend (#2886) Signed-off-by: Nikki Attea <[email protected]> * Feature/cluster id hex (#2893) Signed-off-by: Nikki Attea <[email protected]> * Add support for field selectors (#2892) Signed-off-by: Simon Plourde <[email protected]> * Proxy api from dashboard daemon (#2885) Signed-off-by: James Phillips <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change?
This PR adds functions to retrieve fields for resources that can be listed via the REST API.
It also adds an argument to the lister HTTP handler that correspond to these functions signature.
Why is this change necessary?
Required by https://github.com/sensu/sensu-enterprise-go/issues/283.
Does your change need a Changelog entry?
Added!
Do you need clarification on anything?
Nope!
Were there any complications while making this change?
Nope! I hesitated to add a method to the
Resourceinterface but I decided against it because it could be considered as a breaking change; third-party code relying on it would break with this change.Have you reviewed and updated the documentation for this change? Is new documentation required?
Not yet.
How did you verify this change?
Manual testing.