Move dashboard source code into its own repository #2869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Phillips <[email protected]>
Signed-off-by: James Phillips <[email protected]>
Signed-off-by: James Phillips <[email protected]>
Signed-off-by: James Phillips <[email protected]>
Signed-off-by: James Phillips <[email protected]>
Signed-off-by: James Phillips <[email protected]>
Signed-off-by: James Phillips <[email protected]>
Signed-off-by: James Phillips <[email protected]>
Signed-off-by: James Phillips <[email protected]>
Signed-off-by: James Phillips <[email protected]>
jamesdphillips
changed the title
Signed-off-by: James Phillips <[email protected]>
Adds .ref file stores the git SHA associated with the current state of the asset box. This allows the generate process to avoid updating the box unless sensu/web#master actually has new commits. Signed-off-by: James Phillips <[email protected]>
Signed-off-by: James Phillips <[email protected]>
echlebek
added a commit
that referenced
this pull request
Apr 25, 2019
* Create 5.6.0 release branch Signed-off-by: Eric Chlebek <[email protected]> * Bugfix for annotations & labels flags (#2881) Signed-off-by: Simon Plourde <[email protected]> * Move dashboard source code into its own repository (#2869) As our project has grown, build targets increased, and time has passed, the ideal of a monorepo housing both the web and backend has simply caused more friction than it has reduced. Today we are moving Sensu Go Web into it's own repository: sensu/web. Signed-off-by: James Phillips <[email protected]> * [GraphQL] Ensures that all types are registered (#2875) Types that are not directly referenced by the root Schema type or any of their children are not immediately registered with the schema. As such to ensure that ALL types are available we append any that are missing. Signed-off-by: James Phillips <[email protected]> * Add message bus to tessend (#2886) Signed-off-by: Nikki Attea <[email protected]> * Feature/cluster id hex (#2893) Signed-off-by: Nikki Attea <[email protected]> * Add support for field selectors (#2892) Signed-off-by: Simon Plourde <[email protected]> * Proxy api from dashboard daemon (#2885) Signed-off-by: James Phillips <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As our project has grown, build targets increased, and time has passed, the ideal of a monorepo housing both the web and backend has simply caused more friction than it has reduced. Today we are moving Sensu Go Web into it's own repository: sensu/web.
Asset Embedding
The big change where sensu-go is concerned is how assets are now embedded. Previously running
go generate ./dashboardwould run build the dashboard and generate the asset "box". This process meant that embedding the dashboard required that you have recent versions ofnodeandyarninstalled.Moving forward the process will look like,
sensu/web, CI will upload the build artifacts to S3.sensu-gowe will continue to rungo generate ./dashboard.Reviewer Notes
I apologize for the messy diff; outside of all the deleted files the two that were not deleted and have changed are:
README.md
asset_generate.go
Proposal
Google Doc