chore: prep the repo for automated release #599

eshanholtz · 2020-01-29T21:45:43Z

No description provided.

eshanholtz · 2020-01-29T21:52:15Z

So as far as I can still, this is still going to require manually going into Sonatype to promote the deployment from Staging to Release to get it to Maven Central. I haven't quite figured out why the twilio-java repo doesn't have this manual step, even though we also upload to Sonatype. I'd like some feedback on whether we should try to pivot off of Gradle and set up the repo to be more in line with twilio-java before I propagate similar changes to the other SG java repos.

thinkingserious · 2020-01-30T16:41:31Z

I'm in favor of pivoting from gradle to mvn. However, I have not been able to get it to function properly.

Here are the steps I took:

Made these modifications
Created an Example.java file with the following contents:

import com.sendgrid.*;
import java.io.IOException;

public class Example {
  public static void main(String[] args) throws IOException {
    Email from = new Email("[email protected]");
    String subject = "Hello World from the Twilio SendGrid Java Library!";
    Email to = new Email("[email protected]");
    Content content = new Content("text/html", "<bold>Test Invalid Emails");
    Mail mail = new Mail(from, subject, to, content);

    SendGrid sg = new SendGrid(System.getenv("SENDGRID_API_KEY"));
    Request request = new Request();
    try {
      request.setMethod(Method.POST);
      request.setEndpoint("mail/send");
      request.setBody(mail.build());
      System.out.println(mail.build());
      Response response = sg.api(request);
      System.out.println(response.getStatusCode());
      System.out.println(response.getBody());
      System.out.println(response.getHeaders());
    } catch (IOException ex) {
      throw ex;
    }
  }
}

Tried to compile with:

javac -cp ~/Workspace/twilio-sendgrid/sendgrid-java/target/sendgrid-java-4.4.1-jar-with-dependencies.jar:. ./Example.java

Received these errors:

Example.java
./Example.java:6: error: cannot find symbol
    Email from = new Email("[email protected]");
    ^
  symbol:   class Email
  location: class Example
./Example.java:6: error: cannot find symbol
    Email from = new Email("[email protected]");
                     ^
  symbol:   class Email
  location: class Example
./Example.java:8: error: cannot find symbol
    Email to = new Email("[email protected]");
    ^
  symbol:   class Email
  location: class Example
./Example.java:8: error: cannot find symbol
    Email to = new Email("[email protected]");
                   ^
  symbol:   class Email
  location: class Example
./Example.java:9: error: cannot find symbol
    Content content = new Content("text/html", "<bold>Test Invalid Emails");
    ^
  symbol:   class Content
  location: class Example
./Example.java:9: error: cannot find symbol
    Content content = new Content("text/html", "<bold>Test Invalid Emails");
                          ^
  symbol:   class Content
  location: class Example
./Example.java:10: error: cannot find symbol
    Mail mail = new Mail(from, subject, to, content);
    ^
  symbol:   class Mail
  location: class Example
./Example.java:10: error: cannot find symbol
    Mail mail = new Mail(from, subject, to, content);
                    ^
  symbol:   class Mail
  location: class Example
8 errors

Note that if I download the .jar from here: https://github.com/sendgrid/sendgrid-java/releases/download/v4.4.1/sendgrid-java.jar and run javac -cp ~/Downloads/sendgrid-java.jar:. ./Example.java, compilation is successful.

Also, if I run jar tf ~/Workspace/twilio-sendgrid/sendgrid-java/target/sendgrid-java-4.4.1-jar-with-dependencies.jar, it does seem that the classes are there (note I filtered out all dependencies except sendgrid):

META-INF/MANIFEST.MF
META-INF/
com/
com/sendgrid/
com/sendgrid/helpers/
com/sendgrid/helpers/mail/
com/sendgrid/helpers/mail/objects/
META-INF/maven/com.sendgrid/
META-INF/maven/com.sendgrid/sendgrid-java/
com/sendgrid/Client$1.class
com/sendgrid/Client.class
com/sendgrid/HttpDeleteWithBody.class
com/sendgrid/Method.class
com/sendgrid/Request.class
com/sendgrid/Response.class
com/sendgrid/SendGridResponseHandler.class
com/sendgrid/SendGridAPI.class
com/sendgrid/SendGrid$1.class
com/sendgrid/APICallback.class
com/sendgrid/SendGrid$2.class
com/sendgrid/SendGrid.class
com/sendgrid/helpers/mail/objects/SpamCheckSetting.class
com/sendgrid/helpers/mail/objects/Attachments$Builder.class
com/sendgrid/helpers/mail/objects/OpenTrackingSetting.class
com/sendgrid/helpers/mail/objects/Setting.class
com/sendgrid/helpers/mail/objects/GoogleAnalyticsSetting.class
com/sendgrid/helpers/mail/objects/ASM.class
com/sendgrid/helpers/mail/objects/FooterSetting.class
com/sendgrid/helpers/mail/objects/Personalization.class
com/sendgrid/helpers/mail/objects/Email.class
com/sendgrid/helpers/mail/objects/MailSettings.class
com/sendgrid/helpers/mail/objects/BccSettings.class
com/sendgrid/helpers/mail/objects/Content.class
com/sendgrid/helpers/mail/objects/TrackingSettings.class
com/sendgrid/helpers/mail/objects/ClickTrackingSetting.class
com/sendgrid/helpers/mail/objects/Attachments.class
com/sendgrid/helpers/mail/objects/ContentVerifier.class
com/sendgrid/helpers/mail/objects/SubscriptionTrackingSetting.class
com/sendgrid/helpers/mail/Mail.class
com/sendgrid/RateLimitException.class
META-INF/maven/com.sendgrid/sendgrid-java/pom.xml
META-INF/maven/com.sendgrid/sendgrid-java/pom.properties

Running the above command on the downloaded jar, reveals:

META-INF/
META-INF/MANIFEST.MF
com/sendgrid/
com/sendgrid/SendGridAPI.class
com/sendgrid/SpamCheckSetting.class
com/sendgrid/Attachments$Builder.class
com/sendgrid/OpenTrackingSetting.class
com/sendgrid/SendGridResponseHandler.class
com/sendgrid/Setting.class
com/sendgrid/GoogleAnalyticsSetting.class
com/sendgrid/ASM.class
com/sendgrid/FooterSetting.class
com/sendgrid/Personalization.class
com/sendgrid/Client$1.class
com/sendgrid/Method.class
com/sendgrid/Response.class
com/sendgrid/Email.class
com/sendgrid/Client.class
com/sendgrid/SendGrid$1.class
com/sendgrid/MailSettings.class
com/sendgrid/BccSettings.class
com/sendgrid/Request.class
com/sendgrid/Content.class
com/sendgrid/APICallback.class
com/sendgrid/TrackingSettings.class
com/sendgrid/Mail.class
com/sendgrid/SendGrid$2.class
com/sendgrid/ClickTrackingSetting.class
com/sendgrid/SendGrid.class
com/sendgrid/Attachments.class
com/sendgrid/ContentVerifier.class
com/sendgrid/SubscriptionTrackingSetting.class
com/sendgrid/HttpDeleteWithBody.class
com/sendgrid/RateLimitException.class
com/sendgrid/helpers/
com/sendgrid/helpers/mail/
com/sendgrid/helpers/mail/Mail.class
com/sendgrid/helpers/mail/objects/
com/sendgrid/helpers/mail/objects/SpamCheckSetting.class
com/sendgrid/helpers/mail/objects/Attachments$Builder.class
com/sendgrid/helpers/mail/objects/OpenTrackingSetting.class
com/sendgrid/helpers/mail/objects/Setting.class
com/sendgrid/helpers/mail/objects/GoogleAnalyticsSetting.class
com/sendgrid/helpers/mail/objects/ASM.class
com/sendgrid/helpers/mail/objects/FooterSetting.class
com/sendgrid/helpers/mail/objects/Personalization.class
com/sendgrid/helpers/mail/objects/Email.class
com/sendgrid/helpers/mail/objects/MailSettings.class
com/sendgrid/helpers/mail/objects/BccSettings.class
com/sendgrid/helpers/mail/objects/Content.class
com/sendgrid/helpers/mail/objects/TrackingSettings.class
com/sendgrid/helpers/mail/objects/ClickTrackingSetting.class
com/sendgrid/helpers/mail/objects/Attachments.class
com/sendgrid/helpers/mail/objects/ContentVerifier.class
com/sendgrid/helpers/mail/objects/SubscriptionTrackingSetting.class

I'm currently investigating the differences between the twilio-java pom.xml and the sendgrid-java pom.xml for ideas on what could be missing.

thinkingserious · 2020-01-30T18:10:23Z

If I add these two imports, it works:

import com.sendgrid.helpers.mail.objects.*;
import com.sendgrid.helpers.mail.*;

thinkingserious

Sam wrote some code to upload the packaged file to the release on GitHub for PHP. I believe we want to do the same with the generated jar so that it shows up here: https://github.com/sendgrid/sendgrid-java/releases/tag/v4.4.1

.travis.yml

childish-sambino

test

thinkingserious · 2020-01-31T19:13:31Z

Hello @eshanholtz,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jan 29, 2020

testing mvn vs gradle

9a4db60

thinkingserious and others added 12 commits January 30, 2020 11:01

this works! yay

6ef5722

this works! yay

ec0312c

chore: prep repo for automated releasing

d49719b

feat: add deployment script

24a600e

chore: update build config

27e0ddb

fix: calling deploy script

c2d9e25

fix yaml indentation

8d1c230

update dependencies

86f3159

fix: add oracleJDK 8 to allowed failures

cd506fa

chore: add oraclejdk 7 and 8

90f71e8

remove known failed java version from required builds

279730a

chore: refactor to deploy with mvn

a5005a9

eshanholtz force-pushed the librarian branch from 836a02d to a5005a9 Compare January 30, 2020 21:05

eshanholtz added 2 commits January 30, 2020 13:26

update Makefile to move jar file

ee8a8d6

update pom.xml to set dependency version property

82bf1fa

thinkingserious reviewed Jan 30, 2020

View reviewed changes

.travis.yml Outdated Show resolved Hide resolved

thinkingserious approved these changes Jan 30, 2020

View reviewed changes

remove s3 upload

b1abf0a

childish-sambino reviewed Jan 31, 2020

View reviewed changes

eshanholtz merged commit 6a5d049 into master Jan 31, 2020

eshanholtz deleted the librarian branch January 31, 2020 19:13

This was referenced Feb 4, 2020

add [openjdk11] to Travis build #575

Closed

Travis CI builds are failing #594

Closed

Fixed LicenseTest failure #562

Closed

childish-sambino mentioned this pull request Feb 4, 2020

Junit failed due to LicenseTest #561

Closed

RohanTalip mentioned this pull request Feb 4, 2020

Upgraded gradle wrapper to 4.10.2 and fatjar to 0.3 #459

Closed

6 tasks

childish-sambino mentioned this pull request Jul 16, 2020

Implement auto-deploy to package manager #469

Closed

childish-sambino mentioned this pull request Jul 24, 2020

Updated java-http-client dependency to 4.2.0 #400

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: prep the repo for automated release #599

chore: prep the repo for automated release #599

eshanholtz commented Jan 29, 2020

eshanholtz commented Jan 29, 2020

thinkingserious commented Jan 30, 2020 •

edited

Loading

thinkingserious commented Jan 30, 2020

thinkingserious left a comment

childish-sambino left a comment

thinkingserious commented Jan 31, 2020

chore: prep the repo for automated release #599

chore: prep the repo for automated release #599

Conversation

eshanholtz commented Jan 29, 2020

eshanholtz commented Jan 29, 2020

thinkingserious commented Jan 30, 2020 • edited Loading

thinkingserious commented Jan 30, 2020

thinkingserious left a comment

Choose a reason for hiding this comment

childish-sambino left a comment

Choose a reason for hiding this comment

thinkingserious commented Jan 31, 2020

thinkingserious commented Jan 30, 2020 •

edited

Loading