Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated java-http-client dependency to 4.2.0 #400

Closed
wants to merge 1 commit into from

Conversation

Shobhit1610
Copy link

@Shobhit1610 Shobhit1610 commented Oct 31, 2017

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@SendGridDX
Copy link
Collaborator

SendGridDX commented Oct 31, 2017

CLA assistant check
All committers have signed the CLA.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 31, 2017
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Nov 1, 2017
@mbernier
Copy link
Contributor

mbernier commented Nov 3, 2017

@Shobhit1610

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

@maximn
Copy link

maximn commented Nov 26, 2017

Any ETA for this to be merged?

@thinkingserious
Copy link
Contributor

Hi @maximn,

My apologies, I don't have a specific ETA. We are working to process PRs from oldest to newest temporarily due to the amazing results of Hacktoberfest.

With Best Regards,

Elmer

@maximn
Copy link

maximn commented Nov 28, 2017

OK, note that this is just a version bump of the http lib so the merge should be relatively very easy. Looks like an easy win :)

@maximn
Copy link

maximn commented Jan 1, 2018

Please let me know if anything can be done to expedite it.
Merging it should be very simple as this is a version bump of the http lib which is fully backward compatible.

@thinkingserious
Copy link
Contributor

I think this one is good to go, just waiting for it to pop up on our backlog.

@maximn
Copy link

maximn commented Mar 6, 2018

This is waiting in the backlog for a while ... Any ETA?

@thinkingserious
Copy link
Contributor

Hi @Shobhit1610,

I don't have a good ETA unfortunately. We had around 1,000 open PRs in October and now we are sub 300.

With Best Regards,

Elmer

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap difficulty: easy fix is easy in difficulty and removed hacktoberfest labels Sep 28, 2018
@childish-sambino childish-sambino removed the type: community enhancement feature request not on Twilio's roadmap label Jul 20, 2020
@childish-sambino
Copy link
Contributor

Fixed by #599

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants