Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes 582 - Docker container will now be functional #583

Closed
wants to merge 1 commit into from
Closed

Fixes 582 - Docker container will now be functional #583

wants to merge 1 commit into from

Conversation

albertor24
Copy link

@albertor24 albertor24 commented Aug 8, 2019 •
edited
Loading

Fixes

Fixes #582

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the development branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Fixes the docker container, so that it can be tested again

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Aug 8, 2019
albertor24
albertor24 commented Aug 8, 2019
View reviewed changes
docker/Dockerfile
# Set up default Twilio SendGrid env
WORKDIR /root/sources
RUN git clone https://github.com/sendgrid/sendgrid-java.git
WORKDIR /root
RUN ln -s /root/sources/sendgrid-java

# Use older gradle commands to support the gradle version in the wrapper
RUN sed -i 's/implementation/compile/g' /root/sendgrid-java/build.gradle
Copy link
Author

@albertor24 albertor24 Aug 8, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If anyone has a better idea, or if I am running the command incorrectly, please let me know.

@albertor24 albertor24 changed the title Fxies 582 - Docker container will now be functional Fixes 582 - Docker container will now be functional Aug 9, 2019
@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap difficulty: medium fix is medium in difficulty type: bug bug in the library and removed type: community enhancement feature request not on Twilio's roadmap labels Aug 21, 2019
@rsclarke-vgw rsclarke-vgw mentioned this pull request Nov 6, 2019
Closed
@childish-sambino
Copy link
Contributor

Closing in favor of #626

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio type: bug bug in the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker image non-functional
3 participants
@albertor24 @childish-sambino @thinkingserious