Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image non-functional #582

Closed
albertor24 opened this issue Aug 8, 2019 · 2 comments · Fixed by #626
Closed

Docker image non-functional #582

albertor24 opened this issue Aug 8, 2019 · 2 comments · Fixed by #626
Labels
difficulty: medium fix is medium in difficulty type: bug bug in the library

Comments

@albertor24
Copy link

albertor24 commented Aug 8, 2019

Issue Summary

The instructions in the docker folder are not up to date, and some commands do not work. Moreover, it will be trying to download Prism v3, which will not run when used in the form specified in entrypoint.sh.

Steps to Reproduce

  1. Follow the steps in USAGE.md

Expected behaviour:

Instructions are correct

Actual behaviour:

./gradlew test will fail
prism won't run

Technical details:

  • sendgrid-java Version: master
  • Java Version: As shown in the container
bash-4.2# java -version
java version "1.8.0_211"

I have a PR ready for this, but let me know anything that you may want it to be done differently, or if docker support may be dropped in the future.

@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty status: work in progress Twilio or the community is in the process of implementing type: bug bug in the library labels Aug 21, 2019
@thinkingserious
Copy link
Contributor

Thank you @albertor24! '

We've added this to our backlog for a code review.

With best regards,

Elmer

@childish-sambino
Copy link
Contributor

Fixed by #626

@childish-sambino childish-sambino removed the status: work in progress Twilio or the community is in the process of implementing label Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty type: bug bug in the library
Projects
None yet
3 participants