fix(naming-regressions): fix todos in semgrep-rules related to naming regressions #3444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 7, 2024 20:47
TODO: actually check if this is not a regression
|
These were XFAIL'd mainly because we didn't have |
0xDC0DE
approved these changes
Aug 13, 2024
0xDC0DE
added a commit
that referenced
this pull request
Aug 14, 2024
* Fix CSharp SQLI rule (#3440) * use https instead of http (#3441) * fix(naming-regressions): fix todos in semgrep-rules related to naming regressions (#3444) * Fix todos * Deep got beef'd up :muscleemoji: * bad now good TODO: actually check if this is not a regression * fix rule * Fix misspelling * trying something --------- Co-authored-by: Yosef Alsuhaibani <[email protected]> Co-authored-by: Pieter De Cremer (Semgrep) <[email protected]> --------- Co-authored-by: Lewis <[email protected]> Co-authored-by: Drew Dennison <[email protected]> Co-authored-by: Yosef Alsuhaibani <[email protected]> Co-authored-by: Yosef Alsuhaibani <[email protected]> Co-authored-by: Pieter De Cremer (Semgrep) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contributes to SAF-1000
resolves SAF-1009, SAF-1010, SAF-1011