Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSharp SQLI rule #3440

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Fix CSharp SQLI rule #3440

merged 1 commit into from
Aug 1, 2024

Conversation

LewisArdern
Copy link
Contributor

@LewisArdern LewisArdern commented Jul 31, 2024

Reported by user where taint tracking was 'tainting' due to a string entering SqlConnection first argument, and then a static string was flagging as a finding.

Community slack context https://semgrep.slack.com/archives/C031LV9H6P9/p1722445805060099

Copy link
Member

@inkz inkz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@inkz inkz merged commit e245327 into develop Aug 1, 2024
8 checks passed
@inkz inkz deleted the fixsqlicsharp branch August 1, 2024 05:29
0xDC0DE pushed a commit that referenced this pull request Aug 12, 2024
* Fix CSharp SQLI rule (#3440)

* use https instead of http (#3441)

---------

Co-authored-by: Lewis <[email protected]>
Co-authored-by: Drew Dennison <[email protected]>
0xDC0DE pushed a commit that referenced this pull request Aug 13, 2024
* Fix CSharp SQLI rule (#3440)

* use https instead of http (#3441)

---------

Co-authored-by: Lewis <[email protected]>
Co-authored-by: Drew Dennison <[email protected]>
0xDC0DE added a commit that referenced this pull request Aug 14, 2024
* Fix CSharp SQLI rule (#3440)

* use https instead of http (#3441)

* fix(naming-regressions): fix todos in semgrep-rules related to naming regressions (#3444)

* Fix todos

* Deep got beef'd up :muscleemoji:

* bad now good

TODO: actually check if this is not a regression

* fix rule

* Fix misspelling

* trying something

---------

Co-authored-by: Yosef Alsuhaibani <[email protected]>
Co-authored-by: Pieter De Cremer (Semgrep) <[email protected]>

---------

Co-authored-by: Lewis <[email protected]>
Co-authored-by: Drew Dennison <[email protected]>
Co-authored-by: Yosef Alsuhaibani <[email protected]>
Co-authored-by: Yosef Alsuhaibani <[email protected]>
Co-authored-by: Pieter De Cremer (Semgrep) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants