Scripts for local file migrations. Closes #642. #648
Conversation
There was a problem hiding this comment.
You can also do an action_rename on:
hasOrderedMember -> hasMember.
It might be worth adding in the detect_removed error message that we will be providing sample triples to illustrate the model changes and how they will need to change their data.
Otherwise looks good to me.
|
@Jamie-SA Since you wrote this we have also deleted |
rjyounes
changed the title
|
I've still got a couple more things to do on this PR, but have to switch gears right now and come back to it later. |
I'm not sure what specifically you were referencing. Try to make suggestions for everything that changed? |
|
Yeah, never mind that last comment. |
There was a problem hiding this comment.
Did you add the renaming of the conversion factor predicates I mentioned? I don't see it. Both standardConversionFactor and baseConversionFactor are renamed to conversionFactor.
Once that's done, I think these are good to go unless you want to do anything else.
|
Sorry, missed the conversion factor renaming. I've pushed another change to include that. |
Jamie-SA
changed the title
|
I think I am done now. Please review. |
There was a problem hiding this comment.
This looks good to me. The only thing I would add to the readme is that the migrations scripts are not cumulative - I.e. someone on v9 must upgrade to v10 first and then v11. (That's what I was trying to get at when I suggested mentioning v10, but this is a more generic way to say it.)
|
@bolerio We are aiming to get this merged by EOD today. Will you have a chance to review it before then? |
|
I made a couple more changes to address RY's last comment. |
Migration scripts from v10.0 to v11.0
Closes #642.
I think I covered what we can in the queries
I wrote a very simple test file in
./input/to be able to do some testing.