Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration scripts for deletions and name changes in gist 11 #642

Closed
rjyounes opened this issue Mar 17, 2022 · 2 comments · Fixed by #648
Closed

Migration scripts for deletions and name changes in gist 11 #642

rjyounes opened this issue Mar 17, 2022 · 2 comments · Fixed by #648

Comments

@rjyounes
Copy link
Collaborator

rjyounes commented Mar 17, 2022

As per issue #613. This does not include the datetime model change, which will be handled by providing examples without a script, as detailed in that issue.

@rjyounes
Copy link
Collaborator Author

rjyounes commented Mar 17, 2022

Summary of changes in gist 11

Note: doesn't exclude changes that require no migration, such as modifying annotations and adding or removing a domain or range (even though these affect inferencing).

New time model

Most of the model changes probably should be done manually, because it's not a simple renaming. Object properties have to be renamed to datatype properties, but the properties of the TimeInstant object determine which datatype property to use. It could be automated but would take some work.

Deleted

(I think these get added to detect_removed.rq.)

Classes

TimeInstant
DateInstant
GreenwichInstant
HumanInstant
LocalInstant
SystemInstant

Properties

hasEnd
hasActual
hasActualEnd
hasPlannedEnd
hasDeathDate
hasStart
hasActualStart
hasPlanned
hasBirthDate
hasPlannedStart
epoch
localDate
localDateTime
localTime
universalDate
universalDateTime
universalTime
isSameTimeAs
wasLastModifiedAt

Modified

  • ContemporaneousEvent renamed to ContemporaryEvent
  • usesTimeZoneStandard - domain TimeInstant removed

Added

atDateTime
birthDate
deathDate
endDateTime
actualEndDateTime
actualEndDate
actualEndMicrosecond
actualEndMinute
actualEndYear
plannedEndDateTime
plannedEndDate
plannedEndMinute
plannedEndYear
startDateTime
actualStartDateTime
actualStartDate
actualStartMicrosecond
actualStartMinute
actualStartYear
plannedStartDateTime
plannedStartDate
plannedStartMinute
plannedStartYear

Country and CountryGovernment

There may be no changes to be scripted. Primarily additions, and some formal definitional changes to CountryGovernment.

Miscellaneous

Deleted

  • hasOrderedMember - use hasMember instead
  • hasBiologicalOffspring - change triple :_p gist:hasBiologicalOffspring :_c to : _c gist:hasBiologicalParent :_p.

Modified

  • hasJurisdictionOver renamed isUnderJurisdictionOf - simple renaming, subject and object are not reversed because previous predicate name was an error.

Note: additions may be irrelevant here, but deletions and name changes need to be added to detect_removed.rq.

@Jamie-SA
Copy link
Contributor

Jamie-SA commented Mar 23, 2022

I worked on this some last week. I thought I had most of the queries written but when I went to try to set up a script to run them with onto_tool I ran into the problem that it doesn't support named graphs for local files.

[Edited this to make sense] I debated whether to modify the queries to separate the default graph queries and the named graph queries and only run the default graph queries on local files, or to not support local files. The lack of support for named graphs in local files seems like a major limitation to me.

Do we want to support running migrations on local files when the tools don't support named graphs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants