Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI/wasmbinding to set tokenfactory metadata #989

Merged
merged 4 commits into from
Jul 28, 2023

Conversation

codchen
Copy link
Collaborator

@codchen codchen commented Jul 26, 2023

Describe your changes and provide context

The CLI allow passing in a JSON file, and the wasmbinding takes in a json blob with the same format

Testing performed to validate your change

local sei

@codchen codchen requested a review from Kbhat1 July 26, 2023 04:47
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #989 (ad4a82f) into main (c071491) will decrease coverage by 1.06%.
Report is 2 commits behind head on main.
The diff coverage is 6.94%.

❗ Current head ad4a82f differs from pull request most recent head 1198c0f. Consider uploading reports for the commit 1198c0f to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #989      +/-   ##
==========================================
- Coverage   63.93%   62.88%   -1.06%     
==========================================
  Files         254      256       +2     
  Lines       16234    16497     +263     
==========================================
- Hits        10380    10374       -6     
- Misses       5349     5615     +266     
- Partials      505      508       +3     
Files Changed Coverage Δ
x/tokenfactory/client/cli/tx.go 2.79% <6.94%> (ø)

... and 5 files with indirect coverage changes

@codchen codchen changed the title Add CLI to set tokenfactory metadata Add CLI/wasmbinding to set tokenfactory metadata Jul 26, 2023
@yzang2019
Copy link
Contributor

Can we add an integration test for this new CLI command if it's not too complex?

@codchen codchen force-pushed the tony-chen-tokenfac-cli branch from ad4a82f to 1198c0f Compare July 28, 2023 15:53
@codchen codchen enabled auto-merge (squash) July 28, 2023 15:54
@codchen codchen merged commit 31465d7 into main Jul 28, 2023
@codchen codchen deleted the tony-chen-tokenfac-cli branch July 28, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants