Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Metadata feature for tokenfactory module #932

Closed
hoomp3 opened this issue Jun 26, 2023 · 9 comments
Closed

[FEATURE] Metadata feature for tokenfactory module #932

hoomp3 opened this issue Jun 26, 2023 · 9 comments
Assignees

Comments

@hoomp3
Copy link

hoomp3 commented Jun 26, 2023

Problem

There is no way to set any metadata for tokens created using the token factory module with the method found here - https://github.com/sei-protocol/sei-cosmwasm/tree/main/packages/sei-cosmwasm#tokenfactory. The CreateDenom message in sei_cosmwasm only takes a subdenom as an argument.

As a result, querying for the metadata or token info of a custom native token created by the token factory module returns the following:

photo_2023-06-26 15 15 22

Solution

Users should be able to specify desired metadata when creating native tokens using the token factory. Users should also be able to specify the intended token decimals in addition to the other token metadata (ex: The smallest token amount of ATOM is 10e-6 so this would be 6. The smallest ETH is 10e-18 so this would be 18). This improves the UX of integrating with native tokens since users will be able to rely on getting the metadata from the chain and allows for different custom native tokens to have different token precision.

@hoomp3
Copy link
Author

hoomp3 commented Jul 22, 2023

Any update on this? Hoping it will be part of mainnet.

@BrandonWeng
Copy link
Contributor

@hoomp3 apologies for the delay, there's a PR here for the change. We should be able to get it merged sometime this weekend.

#963

@hoomp3
Copy link
Author

hoomp3 commented Jul 22, 2023

@BrandonWeng okay thanks! when should I expect this update to be reflected here - https://github.com/sei-protocol/sei-cosmwasm?

@BrandonWeng
Copy link
Contributor

@BrandonWeng okay thanks! when should I expect this update to be reflected here - https://github.com/sei-protocol/sei-cosmwasm?

We'll either get it this weekend or early next week!

@hoomp3
Copy link
Author

hoomp3 commented Jul 22, 2023

@BrandonWeng sweet, looking forward to it!

@BrandonWeng
Copy link
Contributor

@hoomp3 apologies for the delay, we're working on the CosmWasm hook and the CLI interface this week.

You can use the RPC/GRPC to interface with the metadata on the chain level.

@hoomp3
Copy link
Author

hoomp3 commented Jul 27, 2023

@BrandonWeng No worries, thanks for letting me know.

@BrandonWeng
Copy link
Contributor

#989

@BrandonWeng
Copy link
Contributor

@hoomp3 it should've just been deployed to atlantic-2 during today's upgrade :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants