Add SetMetadata to tokenfactory #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzang2019
approved these changes
Jul 10, 2023
|
@LCyson can we add a cli command for set denom metadata in tokenfactory |
Metadata request contains too many fields for cli command, users will be recommended to send rpc request to update |
You don’t need to specify all arguments directly via cli. Instead we can read in a json file which specifies the full metadata. Take a look at how we do this for register pair tx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This PR allows the admin of a tokenfactory denom to set its bank.Metadata, thereby changing its display units, name, and symbol.
Testing performed to validate your change