Do not make Sudo call if parameters are empty

x/dex/contract/abci.go

@@ -209,6 +209,9 @@ func handleFinalizedBlocks(ctx context.Context, sdkCtx sdk.Context, env *environ
 		if !contractsNeedHook.Contains(contractAddr) {
 			return true
 		}
+		if len(finalizeBlockMsg.FinalizeBlock.Results) == 0 {
+			return true
+		}
 		if _, err := dexkeeperutils.CallContractSudo(sdkCtx, keeper, contractAddr, finalizeBlockMsg, dexutils.ZeroUserProvidedGas); err != nil {
 			sdkCtx.Logger().Error(fmt.Sprintf("Error calling FinalizeBlock of %s", contractAddr))
 			env.failedContractAddresses.Add(contractAddr)

x/dex/contract/execution.go

@@ -239,7 +239,7 @@ func HandleExecutionForContract(
 	tracer *otrace.Tracer,
 ) (map[string]dextypeswasm.ContractOrderResult, []*types.SettlementEntry, error) {
 	executionStart := time.Now()
-	defer telemetry.ModuleSetGauge(types.ModuleName, float32(time.Since(executionStart).Milliseconds()), "handle_execution_for_contract_ms")
+	defer telemetry.ModuleMeasureSince(types.ModuleName, executionStart, "handle_execution_for_contract_ms")
 	contractAddr := contract.ContractAddr
 	typedContractAddr := dextypesutils.ContractAddress(contractAddr)
 	orderResults := map[string]dextypeswasm.ContractOrderResult{}

x/dex/contract/settlement.go

@@ -24,6 +24,9 @@ func callSettlementHook(
 	dexkeeper *keeper.Keeper,
 	settlementEntries []*types.SettlementEntry,
 ) error {
+	if len(settlementEntries) == 0 {
+		return nil
+	}
 	_, currentEpoch := dexkeeper.IsNewEpoch(ctx)
 	nativeSettlementMsg := dextypeswasm.SudoSettlementMsg{
 		Settlement: types.Settlements{

x/dex/keeper/abci/end_block_cancel_orders.go

@@ -20,6 +20,9 @@ func (w KeeperWrapper) HandleEBCancelOrders(ctx context.Context, sdkCtx sdk.Cont
 
 	typedContractAddr := typesutils.ContractAddress(contractAddr)
 	msg := w.getCancelSudoMsg(sdkCtx, typedContractAddr, registeredPairs)
+	if len(msg.OrderCancellations.IdsToCancel) == 0 {
+		return nil
+	}
 	userProvidedGas := w.GetParams(sdkCtx).DefaultGasPerCancel * uint64(len(msg.OrderCancellations.IdsToCancel))
 	if _, err := utils.CallContractSudo(sdkCtx, w.Keeper, contractAddr, msg, userProvidedGas); err != nil {
 		sdkCtx.Logger().Error(fmt.Sprintf("Error during cancellation: %s", err.Error()))

x/dex/keeper/abci/end_block_deposit.go

@@ -22,6 +22,9 @@ func (w KeeperWrapper) HandleEBDeposit(ctx context.Context, sdkCtx sdk.Context,
 
 	typedContractAddr := typesutils.ContractAddress(contractAddr)
 	msg := w.GetDepositSudoMsg(sdkCtx, typedContractAddr)
+	if msg.IsEmpty() {
+		return nil
+	}
 	_, err := utils.CallContractSudo(sdkCtx, w.Keeper, contractAddr, msg, dexutils.ZeroUserProvidedGas) // deposit
 	if err != nil {
 		sdkCtx.Logger().Error(fmt.Sprintf("Error during deposit: %s", err.Error()))

x/dex/keeper/abci/end_block_place_orders.go

@@ -30,6 +30,9 @@ func (w KeeperWrapper) HandleEBPlaceOrders(ctx context.Context, sdkCtx sdk.Conte
 	responses := []wasm.SudoOrderPlacementResponse{}
 
 	for _, msg := range msgs {
+		if msg.IsEmpty() {
+			continue
+		}
 		userProvidedGas := w.GetParams(sdkCtx).DefaultGasPerOrder * uint64(len(msg.OrderPlacements.Orders))
 		data, err := utils.CallContractSudo(sdkCtx, w.Keeper, contractAddr, msg, userProvidedGas)
 		if err != nil {

x/dex/types/wasm/order_placement.go

@@ -15,6 +15,10 @@ type OrderPlacementMsgDetails struct {
 	Deposits []types.ContractDepositInfo `json:"deposits"`
 }
 
+func (m *SudoOrderPlacementMsg) IsEmpty() bool {
+	return len(m.OrderPlacements.Deposits) == 0 && len(m.OrderPlacements.Orders) == 0
+}
+
 type SudoOrderPlacementResponse struct {
 	UnsuccessfulOrders []UnsuccessfulOrder `json:"unsuccessful_orders"`
 }