Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip evm antehandler on non-secp signatures #1606

Merged
merged 6 commits into from
Apr 29, 2024
Merged

Skip evm antehandler on non-secp signatures #1606

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4b661f7
debug
philipsu522 Apr 29, 2024
9011894
debug
philipsu522 Apr 29, 2024
b96fe5e
skip non-secp signatures fevm antehandler
philipsu522 Apr 29, 2024
67f29e9
fix log
philipsu522 Apr 29, 2024
d71dd43
fix log
philipsu522 Apr 29, 2024
419b947
Merge branch 'main' into seid-evm-ante-fail
philipsu522 Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x/evm/ante/preprocess.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@
}
pk, err := btcec.ParsePubKey(acc.GetPubKey().Bytes(), btcec.S256())
if err != nil {
ctx.Logger().Error(fmt.Sprintf("failed to parse pubkey for %s", err))
ctx.Logger().Debug(fmt.Sprintf("failed to parse pubkey for %s, likely due to the fact that it isn't on secp256k1 curve", "pubkey", acc.GetPubKey()), "err", err)

Check failure on line 361 in x/evm/ante/preprocess.go

View workflow job for this annotation

GitHub Actions / lint 

printf: fmt.Sprintf call needs 1 arg but has 2 args (govet)

Check failure on line 361 in x/evm/ante/preprocess.go

View workflow job for this annotation

GitHub Actions / tests (14) 

fmt.Sprintf call needs 1 arg but has 2 args
continue
}
evmAddr, err := pubkeyToEVMAddress(pk.SerializeUncompressed())
Expand Down
Loading